From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vn8jj-00089f-Py for qemu-devel@nongnu.org; Sun, 01 Dec 2013 10:15:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vn8jc-0007ww-HI for qemu-devel@nongnu.org; Sun, 01 Dec 2013 10:15:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33138 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vn8jc-0007wr-6q for qemu-devel@nongnu.org; Sun, 01 Dec 2013 10:15:00 -0500 Message-ID: <529B526C.9020502@suse.de> Date: Sun, 01 Dec 2013 16:14:52 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1385718225-26379-1-git-send-email-armbru@redhat.com> <1385903630.23603.7.camel@localhost.localdomain> In-Reply-To: <1385903630.23603.7.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2] Pointer properties and device_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , armbru@redhat.com Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, chouteau@adacore.com, blauwirbel@gmail.com, kraxel@redhat.com, aliguori@amazon.com, Paolo Bonzini , edgar.iglesias@gmail.com Am 01.12.2013 14:13, schrieb Marcel Apfelbaum: > On Fri, 2013-11-29 at 10:43 +0100, armbru@redhat.com wrote: >> From: Markus Armbruster >> >> Pointer properties can be set only by code, not by device_add. A >> device with a pointer property can't work with device_add only unless >> the property may remain null. cannot_instantiate_with_device_add_yet >> needs to be set then. PATCH 1/2 sets it when needed and else >> documents why not. PATCH 2/2 documents this for future users of >> pointer properties. >> >> This applies on top of my "[PATCH v4 00/10] Clean up and fix no_user" >> series. >=20 > Even that I am not familiar with this code, I've checked all the change= s > and I agree with them. >=20 > Reviewed-by: Marcel Apfelbaum >=20 > Anyway, I do have a question: > Why not asserting on qdev_device_add if we have a pointer property? When we do device_add / device-add, the guest is usually running and we shouldn't kill a running guest just because the user is trying something stupid that we can easily prevent. ;) The alternative BTW is dropping all those pointer properties and replacing them with link<> properties. Paolo tried that for the OMAP timers once but I fear that series was never picked up...? > Instead of checking only cannot_instantiate_with_device_add_yet, > we can go over properties and if we have a pointer property, assert or > return... Raising an error for certain property types may be an option. Although theoretically the existence of an incompatible property would not necessarily indicate incompatibility to instantiate the device, in practice I believe we don't have such excess properties. Regards, Andreas >=20 > Thanks, > Marcel >=20 >> >> Markus Armbruster (2): >> hw: cannot_instantiate_with_device_add_yet due to pointer props >> qdev: Document that pointer properties kill device_add >> >> hw/audio/marvell_88w8618.c | 2 ++ >> hw/dma/sparc32_dma.c | 2 ++ >> hw/gpio/omap_gpio.c | 4 ++++ >> hw/i2c/omap_i2c.c | 2 ++ >> hw/i2c/smbus_eeprom.c | 2 ++ >> hw/intc/etraxfs_pic.c | 4 ++++ >> hw/intc/grlib_irqmp.c | 2 ++ >> hw/intc/omap_intc.c | 4 ++++ >> hw/net/etraxfs_eth.c | 2 ++ >> hw/net/lance.c | 2 ++ >> include/hw/qdev-properties.h | 17 +++++++++++++++++ >> 11 files changed, 43 insertions(+) >> >=20 >=20 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg