* [U-Boot] [PATCH] trats: usb: Add usb_cable_connected() function
@ 2013-11-13 10:54 Przemyslaw Marczak
2013-11-28 9:16 ` Przemyslaw Marczak
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Przemyslaw Marczak @ 2013-11-13 10:54 UTC (permalink / raw)
To: u-boot
Changes:
- define function usb_cable_connected() in trats board file
which returns 1 if cable is connected and 0 otherwise
- trats.h: add CONFIG_USB_CHECK_CABLE
Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
board/samsung/trats/trats.c | 10 ++++++++++
include/configs/trats.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index 7f61d17..9ed70d3 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -500,6 +500,16 @@ void board_usb_init(void)
debug("USB_udc_probe\n");
s3c_udc_probe(&s5pc210_otg_data);
}
+
+#ifdef CONFIG_USB_CABLE_CHECK
+int usb_cable_connected(void)
+{
+ struct pmic *muic = pmic_get("MAX8997_MUIC");
+ int cable_connected = muic->chrg->chrg_type(muic);
+
+ return !!cable_connected;
+}
+#endif
#endif
static void pmic_reset(void)
diff --git a/include/configs/trats.h b/include/configs/trats.h
index 24ea06b..7f8009e 100644
--- a/include/configs/trats.h
+++ b/include/configs/trats.h
@@ -300,6 +300,7 @@
#define CONFIG_USB_GADGET_S3C_UDC_OTG
#define CONFIG_USB_GADGET_DUALSPEED
#define CONFIG_USB_GADGET_VBUS_DRAW 2
+#define CONFIG_USB_CABLE_CHECK
/* LCD */
#define CONFIG_EXYNOS_FB
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] trats: usb: Add usb_cable_connected() function
2013-11-13 10:54 [U-Boot] [PATCH] trats: usb: Add usb_cable_connected() function Przemyslaw Marczak
@ 2013-11-28 9:16 ` Przemyslaw Marczak
2013-12-02 2:26 ` Minkyu Kang
2013-12-02 12:54 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2 siblings, 0 replies; 6+ messages in thread
From: Przemyslaw Marczak @ 2013-11-28 9:16 UTC (permalink / raw)
To: u-boot
Hello Minkyu,
On 11/13/2013 11:54 AM, Przemyslaw Marczak wrote:
> Changes:
> - define function usb_cable_connected() in trats board file
> which returns 1 if cable is connected and 0 otherwise
> - trats.h: add CONFIG_USB_CHECK_CABLE
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
Could you review this patch, please?
Thanks
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] trats: usb: Add usb_cable_connected() function
2013-11-13 10:54 [U-Boot] [PATCH] trats: usb: Add usb_cable_connected() function Przemyslaw Marczak
2013-11-28 9:16 ` Przemyslaw Marczak
@ 2013-12-02 2:26 ` Minkyu Kang
2013-12-02 12:54 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2 siblings, 0 replies; 6+ messages in thread
From: Minkyu Kang @ 2013-12-02 2:26 UTC (permalink / raw)
To: u-boot
Dear Przemyslaw Marczak,
On 13/11/13 19:54, Przemyslaw Marczak wrote:
> Changes:
> - define function usb_cable_connected() in trats board file
> which returns 1 if cable is connected and 0 otherwise
> - trats.h: add CONFIG_USB_CHECK_CABLE
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> board/samsung/trats/trats.c | 10 ++++++++++
> include/configs/trats.h | 1 +
> 2 files changed, 11 insertions(+)
>
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index 7f61d17..9ed70d3 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -500,6 +500,16 @@ void board_usb_init(void)
> debug("USB_udc_probe\n");
> s3c_udc_probe(&s5pc210_otg_data);
> }
> +
> +#ifdef CONFIG_USB_CABLE_CHECK
> +int usb_cable_connected(void)
> +{
> + struct pmic *muic = pmic_get("MAX8997_MUIC");
Please check that muic is available.
> + int cable_connected = muic->chrg->chrg_type(muic);
> +
> + return !!cable_connected;
I think, cable_connected is unnecessary.
return !!muic->chrg->chrg_type(muic);
> +}
> +#endif
> #endif
>
> static void pmic_reset(void)
> diff --git a/include/configs/trats.h b/include/configs/trats.h
> index 24ea06b..7f8009e 100644
> --- a/include/configs/trats.h
> +++ b/include/configs/trats.h
> @@ -300,6 +300,7 @@
> #define CONFIG_USB_GADGET_S3C_UDC_OTG
> #define CONFIG_USB_GADGET_DUALSPEED
> #define CONFIG_USB_GADGET_VBUS_DRAW 2
> +#define CONFIG_USB_CABLE_CHECK
>
> /* LCD */
> #define CONFIG_EXYNOS_FB
>
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] trats: usb: Add usb_cable_connected() function
2013-11-13 10:54 [U-Boot] [PATCH] trats: usb: Add usb_cable_connected() function Przemyslaw Marczak
2013-11-28 9:16 ` Przemyslaw Marczak
2013-12-02 2:26 ` Minkyu Kang
@ 2013-12-02 12:54 ` Przemyslaw Marczak
2013-12-03 0:35 ` Minkyu Kang
2 siblings, 1 reply; 6+ messages in thread
From: Przemyslaw Marczak @ 2013-12-02 12:54 UTC (permalink / raw)
To: u-boot
Changes:
- define function usb_cable_connected() in trats board file
which returns 1 if cable is connected and 0 otherwise
- trats.h: add CONFIG_USB_CHECK_CABLE
Changes v2:
- add muic avaibility check
Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
board/samsung/trats/trats.c | 11 +++++++++++
include/configs/trats.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index 7012c13..6bd106e 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -501,6 +501,17 @@ int board_usb_init(int index, enum usb_init_type init)
debug("USB_udc_probe\n");
return s3c_udc_probe(&s5pc210_otg_data);
}
+
+#ifdef CONFIG_USB_CABLE_CHECK
+int usb_cable_connected(void)
+{
+ struct pmic *muic = pmic_get("MAX8997_MUIC");
+ if (!muic)
+ return 0;
+
+ return !!muic->chrg->chrg_type(muic);
+}
+#endif
#endif
static void pmic_reset(void)
diff --git a/include/configs/trats.h b/include/configs/trats.h
index 3d080c4..8ff9800 100644
--- a/include/configs/trats.h
+++ b/include/configs/trats.h
@@ -308,6 +308,7 @@
#define CONFIG_USB_GADGET_S3C_UDC_OTG
#define CONFIG_USB_GADGET_DUALSPEED
#define CONFIG_USB_GADGET_VBUS_DRAW 2
+#define CONFIG_USB_CABLE_CHECK
/* LCD */
#define CONFIG_EXYNOS_FB
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] trats: usb: Add usb_cable_connected() function
2013-12-02 12:54 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
@ 2013-12-03 0:35 ` Minkyu Kang
2013-12-03 10:38 ` Przemyslaw Marczak
0 siblings, 1 reply; 6+ messages in thread
From: Minkyu Kang @ 2013-12-03 0:35 UTC (permalink / raw)
To: u-boot
On 02/12/13 21:54, Przemyslaw Marczak wrote:
> Changes:
> - define function usb_cable_connected() in trats board file
> which returns 1 if cable is connected and 0 otherwise
> - trats.h: add CONFIG_USB_CHECK_CABLE
>
> Changes v2:
> - add muic avaibility check
Change log should be under --- line.
This is not a commit message.
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> board/samsung/trats/trats.c | 11 +++++++++++
> include/configs/trats.h | 1 +
> 2 files changed, 12 insertions(+)
>
Anyway...
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] trats: usb: Add usb_cable_connected() function
2013-12-03 0:35 ` Minkyu Kang
@ 2013-12-03 10:38 ` Przemyslaw Marczak
0 siblings, 0 replies; 6+ messages in thread
From: Przemyslaw Marczak @ 2013-12-03 10:38 UTC (permalink / raw)
To: u-boot
Hello,
On 12/03/2013 01:35 AM, Minkyu Kang wrote:
> On 02/12/13 21:54, Przemyslaw Marczak wrote:
>> Changes:
>> - define function usb_cable_connected() in trats board file
>> which returns 1 if cable is connected and 0 otherwise
>> - trats.h: add CONFIG_USB_CHECK_CABLE
>>
>> Changes v2:
>> - add muic avaibility check
>
> Change log should be under --- line.
> This is not a commit message.
>
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>> ---
>> board/samsung/trats/trats.c | 11 +++++++++++
>> include/configs/trats.h | 1 +
>> 2 files changed, 12 insertions(+)
>>
>
> Anyway...
> applied to u-boot-samsung.
>
> Thanks,
> Minkyu Kang.
>
>
Sorry for this issue and thank you for patch apply.
Could you also check my patch to s5p gpio?
Regards
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-03 10:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-13 10:54 [U-Boot] [PATCH] trats: usb: Add usb_cable_connected() function Przemyslaw Marczak
2013-11-28 9:16 ` Przemyslaw Marczak
2013-12-02 2:26 ` Minkyu Kang
2013-12-02 12:54 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2013-12-03 0:35 ` Minkyu Kang
2013-12-03 10:38 ` Przemyslaw Marczak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.