From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VnL98-00044q-Tu
	for qemu-devel@nongnu.org; Sun, 01 Dec 2013 23:30:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VnL94-0004YM-Nn
	for qemu-devel@nongnu.org; Sun, 01 Dec 2013 23:30:10 -0500
Received: from [222.73.24.84] (port=15883 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1VnL94-0004F3-Bb
	for qemu-devel@nongnu.org; Sun, 01 Dec 2013 23:30:06 -0500
Message-ID: <529C0C5B.3010307@cn.fujitsu.com>
Date: Mon, 02 Dec 2013 12:28:11 +0800
From: Li Guang <lig.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1385540635-26977-1-git-send-email-lig.fnst@cn.fujitsu.com>
	<1385540635-26977-2-git-send-email-lig.fnst@cn.fujitsu.com>
	<CAFEAcA_rmG0E_==kP=-T7GR1S+=cjEj43TeiBHg=NEfMrQyOhQ@mail.gmail.com>
	<CAFEAcA8tKW3MErWxOvn_XDx4L-LTih+4xs-oQeGew1wxWg1e9A@mail.gmail.com>
In-Reply-To: <CAFEAcA8tKW3MErWxOvn_XDx4L-LTih+4xs-oQeGew1wxWg1e9A@mail.gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8; format=flowed
Subject: Re: [Qemu-devel] [PATCH v6 1/5] hw/ptimer: add VMSTATE_PTIMER_ARRAY
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>

Peter Maydell wrote:
> On 29 November 2013 11:01, Peter Maydell<peter.maydell@linaro.org>  wrote:
>    
>> On 27 November 2013 08:23, liguang<lig.fnst@cn.fujitsu.com>  wrote:
>>      
>>> Signed-off-by: liguang<lig.fnst@cn.fujitsu.com>
>>> ---
>>>   include/hw/ptimer.h |    3 +++
>>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h
>>> index 28fcaf1..a9b8f1d 100644
>>> --- a/include/hw/ptimer.h
>>> +++ b/include/hw/ptimer.h
>>> @@ -27,6 +27,9 @@ void ptimer_stop(ptimer_state *s);
>>>
>>>   extern const VMStateDescription vmstate_ptimer;
>>>
>>> +#define VMSTATE_PTIMER_ARRAY(_f, _s, _n) \
>>> +    VMSTATE_STRUCT_ARRAY(_f, _s, _n, 0, vmstate_ptimer, ptimer_state*)
>>>        
>> The final parameter here should just be the struct type
>> ("ptimer_state"), not a pointer-to-it.
>>      
> Actually, looking at the patch where you've used this,
> you do actually want to deal with an
> array-of-pointers-to-ptimers. For that you need
>
> #define VMSTATE_PTIMER_ARRAY(_f, _s, _n) \
>      VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_ptimer, ptimer_state *)
>
> (compare VMSTATE_TIMER_ARRAY in vmstate.h)
>
>
>    

OK, thanks!