From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from relay.parallels.com ([195.214.232.42]:58324 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049Ab3LBHXL (ORCPT ); Mon, 2 Dec 2013 02:23:11 -0500 Message-ID: <529C355C.3000609@parallels.com> Date: Mon, 2 Dec 2013 11:23:08 +0400 From: Stanislav Kinsbursky MIME-Version: 1.0 To: Christoph Hellwig , , CC: Subject: Re: [PATCH 00/11] [RFC] repair net namespace damage to rpc_pipefs References: <20131201131441.790963326@bombadil.infradead.org> In-Reply-To: <20131201131441.790963326@bombadil.infradead.org> Content-Type: text/plain; charset="windows-1251"; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: 01.12.2013 17:14, Christoph Hellwig пишет: > As-is this has one major downside: because the initial mount already grabs > a reference to the network namespace we'll create a cyclic reference and > will never free the network namespace. To get around this we'd need > some way to only grab it once user mounts show up / disapear in the VFS. That's a great cleanup of the whole PipeFS mount/umount logic. And it actually moves code to the state it was (with minor changes) before net namespace changes. But the reason for all this "damage" was exactly to remove this major downside and do _not_ tie network namespace to mount point.. So, please, solve the problem before reverting all this notifiers and friends. -- Best regards, Stanislav Kinsbursky From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Kinsbursky Subject: Re: [PATCH 00/11] [RFC] repair net namespace damage to rpc_pipefs Date: Mon, 2 Dec 2013 11:23:08 +0400 Message-ID: <529C355C.3000609@parallels.com> References: <20131201131441.790963326@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: To: Christoph Hellwig , , Return-path: In-Reply-To: <20131201131441.790963326-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org 01.12.2013 17:14, Christoph Hellwig =EF=E8=F8=E5=F2: > As-is this has one major downside: because the initial mount already = grabs > a reference to the network namespace we'll create a cyclic reference = and > will never free the network namespace. To get around this we'd need > some way to only grab it once user mounts show up / disapear in the V= =46S. That's a great cleanup of the whole PipeFS mount/umount logic. And it a= ctually moves code to the state it was (with minor changes) before net namespa= ce changes. But the reason for all this "damage" was exactly to remove this major d= ownside and do _not_ tie network namespace to mount point.. So, please, solve the problem before reverting all this notifiers and f= riends. --=20 Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html