Re: [PATCH] net/mlx4_core: destroy workqueue when driver fails to register

[Amir Vadai <amirv@mellanox.com>]

On 02/12/2013 03:44, Wei Yang wrote:
> When driver registration fails, we need to clean up the resources allocated
> before. mlx4_core missed to destroy the workqueue allocated.
> 
> This patch destroies the workqueue when registration fails.
> 
> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 5789ea2..01fc651 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -2635,6 +2635,8 @@ static int __init mlx4_init(void)
>  		return -ENOMEM;
>  
>  	ret = pci_register_driver(&mlx4_driver);
> +	if (ret < 0)
> +		destroy_workqueue(mlx4_wq);
>  	return ret < 0 ? ret : 0;
>  }
>  
> 

Acked-By: Amir Vadai <amirv@mellanox.com>