All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap:
Date: Mon, 2 Dec 2013 09:28:02 +0100	[thread overview]
Message-ID: <529C4492.6060203@atmel.com> (raw)
In-Reply-To: <20131118143740.cdb5c0ee72b3d68e443afd66@linux-foundation.org>

On 18/11/2013 23:37, Andrew Morton :
> On Mon, 18 Nov 2013 18:20:54 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> From: Linus Pizunski <linus@narrativeteam.com>
>>
>> Update month and day of month to the alarm month/day instead
>> of current day/month when setting the RTC alarm mask.
>>
>> Signed-off-by: Linus Pizunski <linus@narrativeteam.com>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> I changed this to signed-off-by, as you were on the patch delivery path.
>
>> --- a/drivers/rtc/rtc-at91rm9200.c
>> +++ b/drivers/rtc/rtc-at91rm9200.c
>> @@ -220,6 +220,8 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
>>
>>   	at91_alarm_year = tm.tm_year;
>>
>> +	tm.tm_mon = alrm->time.tm_mon;
>> +	tm.tm_mday = alrm->time.tm_mday;
>>   	tm.tm_hour = alrm->time.tm_hour;
>>   	tm.tm_min = alrm->time.tm_min;
>>   	tm.tm_sec = alrm->time.tm_sec;
>
> I queued this for 3.13.  Do we think it warrants a -stable backport?

(I am late, but it seems this one is not sent to Linus yet...)

Well, yes, we can tag this one for "-stable". The patch applies on 
nearly each kernel that I can think about (code is from 2.6.17-ish). But 
this patch applies with an offset...

Best regards,
-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linus@narrativeteam.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap:
Date: Mon, 2 Dec 2013 09:28:02 +0100	[thread overview]
Message-ID: <529C4492.6060203@atmel.com> (raw)
In-Reply-To: <20131118143740.cdb5c0ee72b3d68e443afd66@linux-foundation.org>

On 18/11/2013 23:37, Andrew Morton :
> On Mon, 18 Nov 2013 18:20:54 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> From: Linus Pizunski <linus@narrativeteam.com>
>>
>> Update month and day of month to the alarm month/day instead
>> of current day/month when setting the RTC alarm mask.
>>
>> Signed-off-by: Linus Pizunski <linus@narrativeteam.com>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> I changed this to signed-off-by, as you were on the patch delivery path.
>
>> --- a/drivers/rtc/rtc-at91rm9200.c
>> +++ b/drivers/rtc/rtc-at91rm9200.c
>> @@ -220,6 +220,8 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
>>
>>   	at91_alarm_year = tm.tm_year;
>>
>> +	tm.tm_mon = alrm->time.tm_mon;
>> +	tm.tm_mday = alrm->time.tm_mday;
>>   	tm.tm_hour = alrm->time.tm_hour;
>>   	tm.tm_min = alrm->time.tm_min;
>>   	tm.tm_sec = alrm->time.tm_sec;
>
> I queued this for 3.13.  Do we think it warrants a -stable backport?

(I am late, but it seems this one is not sent to Linus yet...)

Well, yes, we can tag this one for "-stable". The patch applies on 
nearly each kernel that I can think about (code is from 2.6.17-ish). But 
this patch applies with an offset...

Best regards,
-- 
Nicolas Ferre

  reply	other threads:[~2013-12-02  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 17:20 [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap: Nicolas Ferre
2013-11-18 17:20 ` Nicolas Ferre
2013-11-18 22:37 ` Andrew Morton
2013-11-18 22:37   ` Andrew Morton
2013-12-02  8:28   ` Nicolas Ferre [this message]
2013-12-02  8:28     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529C4492.6060203@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.