From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fixed unresolved symbol "at91_pm_set_standby" when built without CONFIG_PM
Date: Mon, 2 Dec 2013 12:08:19 +0100 [thread overview]
Message-ID: <529C6A23.1040900@atmel.com> (raw)
In-Reply-To: <CAP+RiCDKcBwJunmNF89kh1zoT0xKYRWvaBPHnijRafLU2MHf_g@mail.gmail.com>
On 24/11/2013 19:02, Brent Taylor :
> If CONFIG_PM is not defined, then arch/arm/mach-at91/pm.c is not
> compiled in. This patch creates an inline function that does nothing
> if CONFIG_PM is not defined.
Your "Signed-off-by" line is missing. Can you please quickly send it to
me (by just replying to this email)?
Otherwise, seems reasonable:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> arch/arm/mach-at91/pm.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 3ed190c..c5101dc 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -16,7 +16,11 @@
> #include <mach/at91_ramc.h>
> #include <mach/at91rm9200_sdramc.h>
>
> +#ifdef CONFIG_PM
> extern void at91_pm_set_standby(void (*at91_standby)(void));
> +#else
> +static inline void at91_pm_set_standby(void (*at91_standby)(void)) { }
> +#endif
>
> /*
> * The AT91RM9200 goes into self-refresh mode with this command, and will
> --
> 1.8.3.2
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-12-02 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 18:02 [PATCH] fixed unresolved symbol "at91_pm_set_standby" when built without CONFIG_PM Brent Taylor
2013-12-02 11:08 ` Nicolas Ferre [this message]
[not found] ` <CAP+RiCBHRiQ+exZ1iqVawDOb3teQVZkb8C7WmtXPJVN_O_GaBA@mail.gmail.com>
2013-12-02 13:25 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C6A23.1040900@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.