From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 1/6] arm: rename xen/arch/arm/psci.c into vpsci.c Date: Mon, 02 Dec 2013 13:08:36 +0000 Message-ID: <529C8654.10101@linaro.org> References: <1385982538-17855-1-git-send-email-andre.przywara@linaro.org> <1385982538-17855-2-git-send-email-andre.przywara@linaro.org> <529C84CD.8010200@linaro.org> <1385989569.7108.68.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VnTEt-00033O-MC for xen-devel@lists.xenproject.org; Mon, 02 Dec 2013 13:08:39 +0000 Received: by mail-ea0-f172.google.com with SMTP id q10so9042360ead.3 for ; Mon, 02 Dec 2013 05:08:38 -0800 (PST) In-Reply-To: <1385989569.7108.68.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, patches@linaro.org, Andre Przywara , stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 12/02/2013 01:06 PM, Ian Campbell wrote: > On Mon, 2013-12-02 at 13:02 +0000, Julien Grall wrote: >> >> On 12/02/2013 11:08 AM, Andre Przywara wrote: >>> Follow the current convention of prefixing guest related names >>> with "v" by renaming the guest PSCI functionality into vpsci.c to make >>> room for the host PSCI functions. >> >> I would also rename the header asm/psci.h => asm/vpsci.h > > The majority of the header is stuff defined by the spec which is equally > common to be host and guest psci. Apart from a couple of prototypes for > the guest entry points. > > I don't think it makes sense to rename the header, or even to split the > tiny guest side parts into a new vpsci.h In this case, can we at least add "guest" (or something else) in the function name? -- Julien Grall