From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 2/6] arm: move GIC SGI kicking into separate function Date: Mon, 02 Dec 2013 13:16:34 +0000 Message-ID: <529C8832.1090201@linaro.org> References: <1385982538-17855-1-git-send-email-andre.przywara@linaro.org> <1385982538-17855-3-git-send-email-andre.przywara@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VnTMd-0003od-8c for xen-devel@lists.xenproject.org; Mon, 02 Dec 2013 13:16:39 +0000 Received: by mail-ea0-f182.google.com with SMTP id o10so12078409eaj.13 for ; Mon, 02 Dec 2013 05:16:37 -0800 (PST) In-Reply-To: <1385982538-17855-3-git-send-email-andre.przywara@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andre Przywara , Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com Cc: xen-devel@lists.xenproject.org, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 12/02/2013 11:08 AM, Andre Przywara wrote: > Currently we unconditionally send SGIs to all cores on SMP bringup. > PSCI will not need this, so we move this into a function and call it > explicitly from the platforms that need it. This gets us get rid of > the empty cpu_up() platform functions in ARM32 and the comment in > there. > > Signed-off-by: Andre Przywara > --- > xen/arch/arm/arm64/smpboot.c | 2 +- > xen/arch/arm/platform.c | 2 +- > xen/arch/arm/platforms/exynos5.c | 11 +---------- > xen/arch/arm/platforms/omap5.c | 11 +---------- > xen/arch/arm/platforms/vexpress.c | 10 +--------- > xen/arch/arm/smpboot.c | 15 ++++++++++----- > xen/include/asm-arm/smp.h | 2 ++ > 7 files changed, 17 insertions(+), 36 deletions(-) > [..] > diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c > index a7f9ee4..056d462 100644 > --- a/xen/arch/arm/platform.c > +++ b/xen/arch/arm/platform.c > @@ -112,7 +112,7 @@ int __init platform_cpu_up(int cpu) > if ( platform && platform->cpu_up ) > return platform->cpu_up(cpu); > > - return -EAGAIN; > + return -ENODEV; This change seems unrelated to this patch. -- Julien Grall