From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fencing: Add support for ipmitool/amttool binaries during autoconf
Date: Mon, 02 Dec 2013 19:13:58 +0100 [thread overview]
Message-ID: <529CCDE6.7060006@redhat.com> (raw)
In-Reply-To: <1385998794-19881-1-git-send-email-mgrac@redhat.com>
Thanks for doing it, we still need to change the agent to use
IPMITOOL_PATH & co. :)
Fabio
On 12/02/2013 04:39 PM, Marek 'marx' Grac wrote:
> Configuration of autoconf was extended to dynamically find ipmitool/amttool. If the binary is not found on
> the system then we will switch to default values (Fedora/RHEL). Path to binaries is exported and replaced in
> fencebuild using same processes as a version number or sbin/logdir.
> ---
> configure.ac | 6 ++++++
> make/fencebuild.mk | 2 ++
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 6f4baa0..02c46b8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -163,6 +163,9 @@ LOGDIR=${localstatedir}/log/cluster
> CLUSTERVARRUN=${localstatedir}/run/cluster
> CLUSTERDATA=${datadir}/cluster
>
> +## path to 3rd-party binaries
> +AC_PATH_PROG([IPMITOOL_PATH], [ipmitool], [/usr/bin/ipmitool])
> +AC_PATH_PROG([AMTTOOL_PATH], [amttool], [/usr/bin/amttool])
> ## do subst
>
> AC_SUBST([DEFAULT_CONFIG_DIR])
> @@ -187,6 +190,9 @@ AC_SUBST([SNMPBIN])
> AC_SUBST([AGENTS_LIST])
> AM_CONDITIONAL(BUILD_XENAPILIB, test $XENAPILIB -eq 1)
>
> +AC_SUBST([IPMITOOL_PATH])
> +AC_SUBST([AMTTOOL_PATH])
> +
> ## *FLAGS handling
>
> ENV_CFLAGS="$CFLAGS"
> diff --git a/make/fencebuild.mk b/make/fencebuild.mk
> index 15a47fd..5cbe3bd 100644
> --- a/make/fencebuild.mk
> +++ b/make/fencebuild.mk
> @@ -9,6 +9,8 @@ $(TARGET): $(SRC)
> -e 's#@''LOGDIR@#${LOGDIR}#g' \
> -e 's#@''SBINDIR@#${sbindir}#g' \
> -e 's#@''LIBEXECDIR@#${libexecdir}#g' \
> + -e 's#@''IPMITOOL_PATH#${IPMITOOL_PATH}#g' \
> + -e 's#@''AMTTOOL_PATH#${AMTTOOL_PATH}#g' \
> > $@
>
> if [ 0 -eq `echo "$(SRC)" | grep fence_ &> /dev/null; echo $$?` ]; then \
>
prev parent reply other threads:[~2013-12-02 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 15:39 [Cluster-devel] [PATCH] fencing: Add support for ipmitool/amttool binaries during autoconf Marek 'marx' Grac
2013-12-02 18:13 ` Fabio M. Di Nitto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529CCDE6.7060006@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.