Re: [PATCH v0] Make clear that passing --grub-mkimage to grub-install is not supported.

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

On 02.12.2013 20:13, Jon McCune wrote:
> A reasonable alternative would be to completely remove all traces
> of --grub-mkimage, and simply have it fail like any other unrecognized
> flag to grub-install, but this will not be as clear to those who may
> go looking for what has happened to --grub-mkimage.
> 
The reason for this option was to specify where grub-mkimage is located.
Your ways of using it were unsupported interface abuses. I have never
seen any script abusing grub-mkimage such way (that is other than yours).
> Signed-off-by: Jon McCune <jonmccune@google.com>
> ---
>  util/grub-install-common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/util/grub-install-common.c b/util/grub-install-common.c
> index 03c6f13..fcb4d66 100644
> --- a/util/grub-install-common.c
> +++ b/util/grub-install-common.c
> @@ -359,7 +359,8 @@ grub_install_parse (int key, char *arg)
>  	}
>        grub_util_error (_("Unrecognized compression `%s'"), arg);
>      case GRUB_INSTALL_OPTIONS_GRUB_MKIMAGE:
> -      return 1;
> +      grub_util_error (_("Option --grub-mkimage is no longer supported"));
> +      return 0;
>      default:
>        return 0;
>      }
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]