From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mail.openembedded.org (Postfix) with ESMTP id 5F3466DD15 for ; Mon, 2 Dec 2013 20:00:26 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 02 Dec 2013 12:00:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,812,1378882800"; d="scan'208";a="418146094" Received: from unknown (HELO [10.255.15.171]) ([10.255.15.171]) by orsmga001.jf.intel.com with ESMTP; 02 Dec 2013 12:00:25 -0800 Message-ID: <529CE6D9.3090307@linux.intel.com> Date: Mon, 02 Dec 2013 12:00:25 -0800 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Nathan Rossi , openembedded-core@lists.openembedded.org References: <41a9a78e-e827-4551-88c6-78628b1e34da@DB8EHSMHS028.ehs.local> In-Reply-To: <41a9a78e-e827-4551-88c6-78628b1e34da@DB8EHSMHS028.ehs.local> Subject: Re: [PATCH] attr: attr_2.4.47 release tarball missing configure.ac X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 20:00:26 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 11/25/2013 12:18 AM, Nathan Rossi wrote: > The release tarball of attr 2.4.47 is missing the configure.ac file. > This prevents the autotools bbclass from being able to regenerate the > configure script which leads to other side affects. (e.g. using > outdated config.sub) > > This patch adds the configure.ac file via a patch. > (obtained via the source repository at the v2.4.47 tag) > > See the mailing list thread for additional information: > http://lists.nongnu.org/archive/html/acl-devel/2013-05/msg00024.html > > Signed-off-by: Nathan Rossi > --- > > On an additional note, acl 2.2.52 is also affected by this issue. > However it does not affect oe-core as acl has yet to be updated to this > version and currently sits on the older 2.2.51 version. > > --- > meta/recipes-support/attr/attr_2.4.47.bb | 3 + > .../attr/files/attr-Missing-configure.ac.patch | 62 ++++++++++++++++++++ > 2 files changed, 65 insertions(+) > create mode 100644 meta/recipes-support/attr/files/attr-Missing-configure.ac.patch > > diff --git a/meta/recipes-support/attr/attr_2.4.47.bb b/meta/recipes-support/attr/attr_2.4.47.bb > index a1f2e05..ad40c9b 100644 > --- a/meta/recipes-support/attr/attr_2.4.47.bb > +++ b/meta/recipes-support/attr/attr_2.4.47.bb > @@ -1,5 +1,8 @@ > require attr.inc > > +# configure.ac was missing from the release tarball. This should be fixed in > +# future releases of attr, remove this when updating the recipe. > +SRC_URI_append += "file://attr-Missing-configure.ac.patch" > > SRC_URI[md5sum] = "84f58dec00b60f2dc8fd1c9709291cc7" > SRC_URI[sha256sum] = "25772f653ac5b2e3ceeb89df50e4688891e21f723c460636548971652af0a859" > diff --git a/meta/recipes-support/attr/files/attr-Missing-configure.ac.patch b/meta/recipes-support/attr/files/attr-Missing-configure.ac.patch > new file mode 100644 > index 0000000..5887ed5 > --- /dev/null > +++ b/meta/recipes-support/attr/files/attr-Missing-configure.ac.patch > @@ -0,0 +1,62 @@ > +Subject: [PATCH] attr: Missing configure.ac > + > +Upstream-Status: Backport [Upstream released tarball missing this file] You need a Signed-off-by: tag in this patch also Thanks Sau! > +--- > + configure.ac | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > + 1 file changed, 48 insertions(+) > + create mode 100644 configure.ac > + > +diff --git a/configure.ac b/configure.ac > +new file mode 100644 > +index 0000000..b966d0e > +--- /dev/null > ++++ b/configure.ac > +@@ -0,0 +1,48 @@ > ++# Copyright (C) 2009 Andreas Gruenbacher > ++# > ++# This program is free software: you can redistribute it and/or modify it > ++# under the terms of the GNU General Public License as published by > ++# the Free Software Foundation, either version 2 of the License, or > ++# (at your option) any later version. > ++# > ++# This program is distributed in the hope that it will be useful, > ++# but WITHOUT ANY WARRANTY; without even the implied warranty of > ++# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > ++# GNU General Public License for more details. > ++# > ++# You should have received a copy of the GNU General Public License > ++# along with this program. If not, see . > ++# > ++AC_INIT(include/attributes.h) > ++AC_CONFIG_AUX_DIR([.]) > ++AC_CONFIG_MACRO_DIR([m4]) > ++AC_CONFIG_HEADER(include/config.h) > ++AC_PREFIX_DEFAULT(/usr) > ++ > ++AC_PROG_LIBTOOL > ++ > ++AC_ARG_ENABLE(shared, > ++[ --enable-shared=[yes/no] Enable use of shared libraries [default=yes]],, > ++ enable_shared=yes) > ++AC_SUBST(enable_shared) > ++ > ++AC_ARG_ENABLE(gettext, > ++[ --enable-gettext=[yes/no] Enable alternate language support [default=yes]],, > ++ enable_gettext=yes) > ++AC_SUBST(enable_gettext) > ++ > ++AC_ARG_ENABLE(lib64, > ++[ --enable-lib64=[yes/no] Enable lib64 support [default=no]],, > ++ enable_lib64=no) > ++AC_SUBST(enable_lib64) > ++ > ++AC_PACKAGE_GLOBALS(attr) > ++AC_PACKAGE_UTILITIES(attr) > ++AC_MANUAL_FORMAT > ++AC_MULTILIB($enable_lib64) > ++ > ++AC_C_CONST > ++AC_TYPE_MODE_T > ++AC_FUNC_ALLOCA > ++ > ++AC_OUTPUT(include/builddefs) >