From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VngSG-0006X8-C0 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 22:15:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VngS8-0000Rt-3s for qemu-devel@nongnu.org; Mon, 02 Dec 2013 22:15:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VngS7-0000Rn-RQ for qemu-devel@nongnu.org; Mon, 02 Dec 2013 22:15:12 -0500 Message-ID: <529D4CBB.1050704@redhat.com> Date: Mon, 02 Dec 2013 20:15:07 -0700 From: Eric Blake MIME-Version: 1.0 References: <1385714473-7322-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1385714473-7322-9-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1385714473-7322-9-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="65BLE44xoN1WI8cqugbJOc4eN1OJkDQtt" Subject: Re: [Qemu-devel] [PATCH V3 8/9] qapi: convert BlockdevOptions to use enum discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --65BLE44xoN1WI8cqugbJOc4eN1OJkDQtt Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/29/2013 01:41 AM, Wenchao Xia wrote: > After this patch, hidden enum type BlockdevOptionsKind will not > be generated, and other API can use enum BlockdevDriver. >=20 > Signed-off-by: Wenchao Xia > --- > qapi-schema.json | 14 +++++++++++++- > 1 files changed, 13 insertions(+), 1 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 83fa485..ce9197d 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -4024,6 +4024,18 @@ > '*no-flush': 'bool' } } > =20 > ## > +# @BlockdevDriver > +# > +# Drivers that are supported in block device operations. > +# > +# Since: 2.0 It will be interesting documenting any drivers that are added after 2.0, but we can worry about that when it happens. Looks good! Reviewed-by: Eric Blake > +## > +{ 'enum': 'BlockdevDriver', > + 'data': [ 'file', 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', '= bochs', > + 'cloop', 'cow', 'dmg', 'parallels', 'qcow', 'qcow2', 'qed'= , 'raw', > + 'vdi', 'vhdx', 'vmdk', 'vpc' ] } > + > +## --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --65BLE44xoN1WI8cqugbJOc4eN1OJkDQtt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSnUy7AAoJEKeha0olJ0NqTSQIAIuLvZSKtgKQP0TA5lQ6s28N lmUkXz4QXdS7ieN6Oy5Jp4o3ddMk+TiV+fJ95xXuROivB9rsqQ4bAHtqptwbrwyC eJnQKAZvms2C0BkAKvjhjuvs5q0y0vbypgaB0M62KnuxGvpKyrJmOMv+iH+tKwtZ Ij23Haftvw0maHhDKDdnY/8UZrIGMezfaipd9PH6OpTdpMdm6OKg4laiZ7fb8OSp b8ikeFHuAzWLjzYqvPye/ATNKPEPJnaCNlcXPaYUEPeQLJ2YRRkIDWjybeaf6NJK qHL1Tu48u1SqOZ7G8kKoZ83Eu3uMTr87ul14YNsmm6l0xmdMpw+XnUlLsIoT5sA= =jo4W -----END PGP SIGNATURE----- --65BLE44xoN1WI8cqugbJOc4eN1OJkDQtt--