From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Weidong Date: Tue, 03 Dec 2013 06:30:26 +0000 Subject: [PATCH] sctp: disable max_burst when the max_burst is 0 Message-Id: <529D7A82.3070207@huawei.com> List-Id: References: <529C2E01.3090005@huawei.com> <20131202115640.GA10857@hmsreliant.think-freely.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller , Neil Horman , Vlad Yasevich Cc: Michael Tuexen , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, dingtianhong@huawei.com As Michael pointed out that when max_burst is 0, it just disable max_burst. It declared in rfc6458#section-8.1.24. so add the check in sctp_transport_burst_limited, when it 0, just do nothing. Suggested-by: Vlad Yasevich Suggested-by: Michael Tuexen Signed-off-by: Wang Weidong --- net/sctp/transport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sctp/transport.c b/net/sctp/transport.c index e332efb..e580e34 100644 --- a/net/sctp/transport.c +++ b/net/sctp/transport.c @@ -573,7 +573,8 @@ void sctp_transport_burst_limited(struct sctp_transport *t) u32 old_cwnd = t->cwnd; u32 max_burst_bytes; - if (t->burst_limited) + /* if the max_burst is 0, do notihing */ + if (t->burst_limited || !asoc->max_burst) return; max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu); -- 1.7.12 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Weidong Subject: [PATCH] sctp: disable max_burst when the max_burst is 0 Date: Tue, 3 Dec 2013 14:30:26 +0800 Message-ID: <529D7A82.3070207@huawei.com> References: <529C2E01.3090005@huawei.com> <20131202115640.GA10857@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Michael Tuexen , , , To: David Miller , Neil Horman , Vlad Yasevich Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:43031 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106Ab3LCGbL (ORCPT ); Tue, 3 Dec 2013 01:31:11 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: As Michael pointed out that when max_burst is 0, it just disable max_burst. It declared in rfc6458#section-8.1.24. so add the check in sctp_transport_burst_limited, when it 0, just do nothing. Suggested-by: Vlad Yasevich Suggested-by: Michael Tuexen Signed-off-by: Wang Weidong --- net/sctp/transport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sctp/transport.c b/net/sctp/transport.c index e332efb..e580e34 100644 --- a/net/sctp/transport.c +++ b/net/sctp/transport.c @@ -573,7 +573,8 @@ void sctp_transport_burst_limited(struct sctp_transport *t) u32 old_cwnd = t->cwnd; u32 max_burst_bytes; - if (t->burst_limited) + /* if the max_burst is 0, do notihing */ + if (t->burst_limited || !asoc->max_burst) return; max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu); -- 1.7.12