All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM/VExpress: fix timer address for TC2 and other VExpress models
Date: Tue, 03 Dec 2013 09:17:03 +0100	[thread overview]
Message-ID: <529D937F.9000704@linaro.org> (raw)
In-Reply-To: <1385803208.23632.34.camel@dagon.hellion.org.uk>

On 11/30/2013 10:20 AM, Ian Campbell wrote:
> On Tue, 2013-11-26 at 15:20 +0100, Andre Przywara wrote:
>> Commit v2013.10-189-gb3a7f22 breaks u-boot on the VExpress TC2, since
>> the hardcoded value for SP804 timer address is wrong on Versatile
>> Express boards using the extended memory map.
>> Replace this value with an existing macro make it work on both sets of
>> machines.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
>
> I sent out a similar patch a couple of weeks back:
> http://lists.denx.de/pipermail/u-boot/2013-November/167316.html
>
> I don't mind which one goes in, so for this one:
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks Ian and sorry for not searching the list more carefully.

Tom, Albert,

can someone please commit this? This is a serious regression against 
2013.10 and reliably hangs u-boot before showing the prompt.

Thanks,
Andre.

>> ---
>>   include/configs/vexpress_common.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress_common.h
>> index 6da5e8f..7e78f8a 100644
>> --- a/include/configs/vexpress_common.h
>> +++ b/include/configs/vexpress_common.h
>> @@ -132,7 +132,7 @@
>>   #define VEXPRESS_FLASHPROG_FLVPPEN	(1 << 0)
>>
>>   #define CONFIG_SYS_TIMER_RATE		1000000
>> -#define CONFIG_SYS_TIMER_COUNTER	(0x10011000 + 0x4)
>> +#define CONFIG_SYS_TIMER_COUNTER	(V2M_TIMER01 + 0x4)
>>   #define CONFIG_SYS_TIMER_COUNTS_DOWN
>>
>>   /* SMSC9115 Ethernet from SMSC9118 family */
>
>

      reply	other threads:[~2013-12-03  8:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 14:20 [U-Boot] [PATCH] ARM/VExpress: fix timer address for TC2 and other VExpress models Andre Przywara
2013-11-30  9:20 ` Ian Campbell
2013-12-03  8:17   ` Andre Przywara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529D937F.9000704@linaro.org \
    --to=andre.przywara@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.