From: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, j@w1.fi
Subject: Re: [RFC] cfg80211/mac80211: drop GTK-protected unicast IP packets
Date: Tue, 03 Dec 2013 11:41:36 +0100 [thread overview]
Message-ID: <529DB560.40805@lri.fr> (raw)
In-Reply-To: <1386063957.4393.4.camel@jlt4.sipsolutions.net>
On 03/12/2013 10:45, Johannes Berg wrote:
> On Tue, 2013-12-03 at 10:44 +0100, Nicolas Cavallari wrote:
>> On 02/12/2013 19:51, Johannes Berg wrote:
>>> + if (!ipv4_is_multicast(ip.hdr4.daddr))
>>> + return -1;
>>
>> So broadcasting to e.g. 192.168.255.255 is now forbidden ?
>
> Please, read the patch :)
I read the patch further. ipv4_is_multicast only checks if the
address is in 224/4, so this patch makes __ieee80211_data_to_8023
returns 0 for 224.0.0.0 to 239.255.255.255, and returns -1 for
everything else, including the 255.255.255.255, 192.168.255.255 and
other limited broadcast addresses, which are actually indistinguishable
from unicast addresses if you don't know the IP configuration.
If __ieee80211_data_to_8023 returns -1, the packet is dropped as
being unusable -- no less.
next prev parent reply other threads:[~2013-12-03 10:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 18:51 [RFC] cfg80211/mac80211: drop GTK-protected unicast IP packets Johannes Berg
2013-12-03 8:52 ` Pontus Fuchs
2013-12-03 8:54 ` Johannes Berg
2013-12-03 9:20 ` Krishna Chaitanya
2013-12-03 9:34 ` Johannes Berg
2013-12-03 11:16 ` Krishna Chaitanya
2013-12-03 9:44 ` Nicolas Cavallari
2013-12-03 9:45 ` Johannes Berg
2013-12-03 10:41 ` Nicolas Cavallari [this message]
2013-12-03 10:43 ` Nicolas Cavallari
2013-12-03 10:48 ` Johannes Berg
2013-12-03 10:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DB560.40805@lri.fr \
--to=nicolas.cavallari@lri.fr \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.