From: micky <micky_ching@realsil.com.cn>
To: Lee Jones <lee.jones@linaro.org>
Cc: <sameo@linux.intel.com>, <devel@linuxdriverproject.org>,
<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<wei_wang@realsil.com.cn>, <rogerable@realtek.com>
Subject: Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings
Date: Tue, 3 Dec 2013 18:54:37 +0800 [thread overview]
Message-ID: <529DB86D.3010002@realsil.com.cn> (raw)
In-Reply-To: <20131203104003.GJ11828@lee--X1>
On 12/03/2013 06:40 PM, Lee Jones wrote:
> This should contain the author's name.
>
> You should use:
> `git rebase -i` /* Use edit option */
> then
> `git commit --amend --author="First Last <first.last@email.com>"
>
> To apply it.
>
Sorry Lee, I will modify it. Is the order important? or only your name
is need here?
>> drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
>> drivers/mfd/rtl8411.c:58:7: warning: 'reg1' is used uninitialized in this function [-Wuninitialized]
>> drivers/mfd/rtl8411.c: In function 'rtl8411b_fetch_vendor_settings':
>> drivers/mfd/rtl8411.c:79:7: warning: 'reg' is used uninitialized in this function [-Wuninitialized]
>> drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
>> drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this function [-Wuninitialized]
>>
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>> Tested-by: Micky Ching <micky_ching@realsil.com.cn>
> I know this is a bit of a strange situation, but whenever you sent
> patches to the MLs, you need to sign it off yourself too.
>
>
Did you mean I need write like this ?
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Tested-by: Micky Ching <micky_ching@realsil.com.cn>
Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
--
Best Regards
Micky.
next prev parent reply other threads:[~2013-12-03 10:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 9:26 [PATCH v2 0/3] mfd: rtsx: decrease driver size and add new device micky_ching
2013-12-03 9:26 ` [PATCH v2 1/3] mfd: rtsx: reduce code duplication in rtl8411 micky_ching
2013-12-03 10:55 ` Lee Jones
2013-12-03 9:26 ` [PATCH v2 2/3] mfd: rtsx: add card reader rtl8402 micky_ching
2013-12-03 10:45 ` Lee Jones
2013-12-03 11:02 ` micky
2013-12-03 9:26 ` [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings micky_ching
2013-12-03 10:40 ` Lee Jones
2013-12-03 10:40 ` Lee Jones
2013-12-03 11:03 ` micky
2013-12-03 11:28 ` Lee Jones
2013-12-03 10:54 ` micky [this message]
2013-12-03 11:01 ` Lee Jones
2013-12-03 11:07 ` micky
2013-12-03 11:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DB86D.3010002@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.