From: David Vrabel <david.vrabel@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
Julien Grall <julien.grall@linaro.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH RFC] xen-block: correctly define structures in public headers
Date: Tue, 3 Dec 2013 11:01:27 +0000 [thread overview]
Message-ID: <529DBA07.6090108@citrix.com> (raw)
In-Reply-To: <1386068254-1413-1-git-send-email-roger.pau@citrix.com>
On 03/12/13 10:57, Roger Pau Monne wrote:
> Using __packed__ on the public interface is not correct, this
> structures should be compiled using the native ABI, and __packed__
> should only be used in the backend counterpart of those structures
> (which needs to handle different ABIs).
>
> This was even worse in the ARM case, where the Linux kernel was
> incorrectly using the X86_32 protocol ABI. This patch fixes it, but
> also breaks compatibility, so an ARM DomU kernel compiled with
> this patch will fail to communicate with PV disk devices unless the
> Dom0 also has this patch.
This ABI change needs to be justified. Why do you think it is
acceptable to break existing Linux guests? Because I don't think it is.
David
next prev parent reply other threads:[~2013-12-03 11:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 10:57 [PATCH RFC] xen-block: correctly define structures in public headers Roger Pau Monne
2013-12-03 11:01 ` David Vrabel [this message]
2013-12-03 11:07 ` [Xen-devel] " Paul Durrant
2013-12-03 11:07 ` Paul Durrant
2013-12-03 11:08 ` Ian Campbell
2013-12-03 11:08 ` [Xen-devel] " Ian Campbell
2013-12-03 11:59 ` David Vrabel
2013-12-03 13:41 ` Ian Campbell
2013-12-03 15:11 ` David Vrabel
2013-12-03 15:17 ` Ian Campbell
2013-12-03 15:17 ` [Xen-devel] " Ian Campbell
2013-12-03 15:51 ` One Thousand Gnomes
2013-12-03 15:51 ` [Xen-devel] " One Thousand Gnomes
2013-12-03 16:06 ` Ian Campbell
2013-12-03 16:06 ` [Xen-devel] " Ian Campbell
2013-12-03 20:11 ` Konrad Rzeszutek Wilk
2013-12-03 20:11 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-12-04 9:28 ` Ian Campbell
2013-12-04 9:28 ` [Xen-devel] " Ian Campbell
2013-12-04 9:43 ` Roger Pau Monné
2013-12-04 9:43 ` Roger Pau Monné
2013-12-04 12:10 ` [Xen-devel] " Ian Campbell
2013-12-04 12:10 ` Ian Campbell
2013-12-04 11:03 ` Stefano Stabellini
2013-12-04 11:03 ` [Xen-devel] " Stefano Stabellini
2013-12-04 11:33 ` Stefano Stabellini
2013-12-04 11:33 ` Stefano Stabellini
2013-12-11 16:18 ` Stefano Stabellini
2013-12-11 16:18 ` [Xen-devel] " Stefano Stabellini
2013-12-11 16:23 ` Roger Pau Monné
2013-12-11 16:23 ` [Xen-devel] " Roger Pau Monné
2013-12-11 16:29 ` Stefano Stabellini
2013-12-11 16:29 ` Stefano Stabellini
2013-12-03 15:11 ` David Vrabel
2013-12-03 13:41 ` Ian Campbell
2013-12-03 11:59 ` David Vrabel
2013-12-03 11:09 ` Roger Pau Monné
2013-12-03 11:09 ` Roger Pau Monné
2013-12-03 11:01 ` David Vrabel
2013-12-03 11:05 ` Ian Campbell
2013-12-03 11:05 ` [Xen-devel] " Ian Campbell
2013-12-03 11:11 ` Jan Beulich
2013-12-03 11:11 ` [Xen-devel] " Jan Beulich
2013-12-03 11:15 ` Ian Campbell
2013-12-03 11:15 ` Ian Campbell
2013-12-03 11:14 ` Roger Pau Monné
2013-12-03 11:14 ` [Xen-devel] " Roger Pau Monné
2013-12-03 11:14 ` Jan Beulich
2013-12-03 11:14 ` [Xen-devel] " Jan Beulich
2013-12-03 11:18 ` Roger Pau Monné
2013-12-03 11:18 ` [Xen-devel] " Roger Pau Monné
-- strict thread matches above, loose matches on Subject: below --
2013-12-03 10:57 Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DBA07.6090108@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.