From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Paul Durrant <paul.durrant@citrix.com>,
xen-devel@lists.xen.org, netdev@vger.kernel.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH net] xen-netback: clear vif->task on disconnect
Date: Tue, 03 Dec 2013 16:23:30 +0400 [thread overview]
Message-ID: <529DCD42.4070702@cogentembedded.com> (raw)
In-Reply-To: <1386064427-31008-1-git-send-email-paul.durrant@citrix.com>
Hello.
On 03-12-2013 13:53, Paul Durrant wrote:
> xenvif_start_xmit() relies on checking vif->task for NULL to determine
> whether the vif is ready to accept packets. The task thread is stopped in
> xenvif_disconnect() but task is not set to NULL. Thus, on a re-connect the
> check will give a false positive.
> Also since commit ea732dff5cfa10789007bf4a5b935388a0bb2a8f it should not
Please also specify that commit's summary line in parens.
> be possible for xenvif_connect() to be called if the vif is already connected
> so change the check of vif->tx_irq to a BUG_ON() and also add a
> BUG_ON(vif->task).
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
WBR, Sergei
next prev parent reply other threads:[~2013-12-03 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 9:53 [PATCH net] xen-netback: clear vif->task on disconnect Paul Durrant
2013-12-03 12:23 ` Sergei Shtylyov [this message]
2013-12-03 12:23 ` Sergei Shtylyov
2013-12-03 13:38 ` Wei Liu
2013-12-03 13:38 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2013-12-03 9:53 Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DCD42.4070702@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.