From: David Ahern <dsahern@gmail.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: acme@ghostprotocols.net, linux-kernel@vger.kernel.org,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
namhyung@kernel.org,
"yrl.pp-manager.tt@hitachi.com" <yrl.pp-manager.tt@hitachi.com>
Subject: Re: [PATCH 2/2] perf probe: Allow user to specify address within executable
Date: Tue, 03 Dec 2013 08:58:06 -0700 [thread overview]
Message-ID: <529DFF8E.2030806@gmail.com> (raw)
In-Reply-To: <529DA355.9090408@hitachi.com>
On 12/3/13, 2:24 AM, Masami Hiramatsu wrote:
> I don't want to make perf-probe just a wrapper of the ftrace dynamic
> event interface, because it doesn't add any "value" for users.
Sure it does -- a consistent user experience in using a single command
(perf probe ...) for setting up userspace probes.
Specifying the address directly is really on par with perf-record having
the rNNN interface for directly passing the raw event id to the kernel.
>
>>>> In that case, you should use uprobe_events interface directly.
>>>
>>> How do I do that within the context of perf?
>
> No way, but here, you can save this script as perf-uprobe and
> can use it for that purpose. :)
I figured out what you meant by uprobe_events interface yesterday. If I
have to go to that interface for even 1 function I would do it for all
-- from a user perspective it is just simpler to have 1 command to setup
probes. I would prefer that 1 command be perf-probe.
David
next prev parent reply other threads:[~2013-12-03 15:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 0:07 [PATCH 1/2] perf probe: Improve error message when function not found David Ahern
2013-12-02 0:07 ` [PATCH 2/2] perf probe: Allow user to specify address within executable David Ahern
2013-12-02 5:53 ` Masami Hiramatsu
2013-12-02 6:15 ` Masami Hiramatsu
2013-12-02 14:49 ` David Ahern
2013-12-02 17:55 ` David Ahern
2013-12-03 9:24 ` Masami Hiramatsu
2013-12-03 15:58 ` David Ahern [this message]
2013-12-04 1:22 ` Masami Hiramatsu
2013-12-04 1:44 ` David Ahern
2013-12-04 7:39 ` Masami Hiramatsu
2013-12-08 17:50 ` David Ahern
2013-12-02 5:59 ` [PATCH 1/2] perf probe: Improve error message when function not found Masami Hiramatsu
2013-12-02 14:52 ` David Ahern
2013-12-03 5:12 ` Masami Hiramatsu
2013-12-03 15:15 ` David Ahern
2013-12-04 1:23 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529DFF8E.2030806@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.