All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Stephane Eranian <eranian@google.com>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/7] perf script: Add an option to print the source line number
Date: Tue, 03 Dec 2013 09:04:06 -0700	[thread overview]
Message-ID: <529E00F6.7000802@gmail.com> (raw)
In-Reply-To: <1386055390-13757-3-git-send-email-adrian.hunter@intel.com>

On 12/3/13, 12:23 AM, Adrian Hunter wrote:
> @@ -348,6 +355,24 @@ static void print_sample_start(struct perf_sample *sample,
>   	}
>   }
>
> +static void print_sample_finish(struct perf_evsel *evsel,
> +				struct addr_location *al)
> +{
> +	struct perf_event_attr *attr = &evsel->attr;
> +
> +	if (PRINT_FIELD(SRCLINE) && al->map && al->map->dso) {
> +		char *srcline;
> +
> +		srcline = get_srcline(al->map->dso,
> +				      map__rip_2objdump(al->map, al->addr));
> +		if (srcline != SRCLINE_UNKNOWN)
> +			printf("\n  %s", srcline);
> +		free_srcline(srcline);
> +	}
> +
> +	printf("\n");
> +}
> +
>   static bool is_bts_event(struct perf_event_attr *attr)
>   {
>   	return ((attr->type == PERF_TYPE_HARDWARE) &&
> @@ -438,7 +463,7 @@ static void print_sample_bts(union perf_event *event,
>   	     !output[attr->type].user_set))
>   		print_sample_addr(event, sample, machine, thread, attr);
>
> -	printf("\n");
> +	print_sample_finish(evsel, al);
>   }
>
>   static void process_event(union perf_event *event, struct perf_sample *sample,
> @@ -480,7 +505,7 @@ static void process_event(union perf_event *event, struct perf_sample *sample,
>   				     PERF_MAX_STACK_DEPTH);
>   	}
>
> -	printf("\n");
> +	print_sample_finish(evsel, al);
>   }
>
>   static int default_start_script(const char *script __maybe_unused,

What about callchains?

David


  reply	other threads:[~2013-12-03 16:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  7:23 [PATCH 0/7] perf script: Add an option to print the source line number Adrian Hunter
2013-12-03  7:23 ` [PATCH 1/7] perf script: Do not call perf_event__preprocess_sample() twice) Adrian Hunter
2013-12-03 18:23   ` Arnaldo Carvalho de Melo
2013-12-04 14:09     ` Adrian Hunter
2013-12-04 14:16       ` [PATCH V2 " Adrian Hunter
2013-12-10  9:17         ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-12-03  7:23 ` [PATCH 2/7] perf script: Add an option to print the source line number Adrian Hunter
2013-12-03 16:04   ` David Ahern [this message]
2013-12-03 16:07     ` David Ahern
2013-12-03  7:23 ` [PATCH 3/7] perf tools: Use asprintf instead of malloc plus snprintf Adrian Hunter
2013-12-10  9:15   ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-12-03  7:23 ` [PATCH 4/7] perf tools: Retain bfd reference to lookup source line numbers Adrian Hunter
2013-12-10  9:15   ` [tip:perf/core] perf symbols: " tip-bot for Adrian Hunter
2013-12-03  7:23 ` [PATCH 5/7] perf tools: Retain symbol source file name " Adrian Hunter
2013-12-10  9:15   ` [tip:perf/core] perf symbols: " tip-bot for Adrian Hunter
2013-12-03  7:23 ` [PATCH 6/7] perf tools: Do not need to read symbols for source line lookup Adrian Hunter
2013-12-03 20:24   ` Arnaldo Carvalho de Melo
2013-12-04 14:00     ` Adrian Hunter
2013-12-04 18:08       ` Arnaldo Carvalho de Melo
2013-12-03  7:23 ` [PATCH 7/7] perf tools: Do not disable source line lookup just because of 1 failure Adrian Hunter
2013-12-10  9:16   ` [tip:perf/core] " tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529E00F6.7000802@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.