From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Convert termios to RCU (was Re: [PATCH tty-next 0/4] tty: Fix ^C echo) Date: Tue, 03 Dec 2013 12:23:24 -0500 Message-ID: <529E138C.4010503@hurleysoftware.com> References: <1386018725-4781-1-git-send-email-peter@hurleysoftware.com> <20131203000116.0d512b59@alan.etchedpixels.co.uk> <529D4E58.9020101@hurleysoftware.com> <20131203142011.371067ea@alan.etchedpixels.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout32.mail01.mtsvc.net ([216.70.64.70]:52089 "EHLO n23.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752989Ab3LCRX3 (ORCPT ); Tue, 3 Dec 2013 12:23:29 -0500 In-Reply-To: <20131203142011.371067ea@alan.etchedpixels.co.uk> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: One Thousand Gnomes Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org On 12/03/2013 09:20 AM, One Thousand Gnomes wrote: > As a PS: I think the termios is probably an RCU problem. The semaphore > seemed to make sense when I did it, but in hindsight I think I made the > wrong call. Alan, Converting safe termios access to RCU is a really good idea. Massive changeset though, if only because tty->termios would have to be a struct termios __rcu *. Regards, Peter Hurley