All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Tao <bergwolf@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH 7/9] staging/lustre/llite: remove ll_file_get_iov_count
Date: Wed, 04 Dec 2013 01:26:31 +0800	[thread overview]
Message-ID: <529E1447.5070903@gmail.com> (raw)
In-Reply-To: <20131203170028.GA9063@kroah.com>

On 12/04/2013 01:00 AM, Greg Kroah-Hartman wrote:
> On Tue, Dec 03, 2013 at 10:42:06PM +0800, Peng Tao wrote:
>> It exactly copies generic_segment_checks() except wrongly calling
>> access_ok(VERIFY_READ) for aio read range. Drop it and just call
>> generic_segment_checks() instead.
>>
>> Signed-off-by: Peng Tao <bergwolf@gmail.com>
>> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
>> ---
>>   drivers/staging/lustre/lustre/llite/file.c |   36 ++--------------------------
>>   1 file changed, 2 insertions(+), 34 deletions(-)
>
> This patch breaks the build, in numerous ways, which means you didn't
> even build test this patch.
>
> PLEASE be more careful, it's getting such that I really dread seeing
> these patches show up in my inbox...
I am truly sorry. This one was added in the last and got in the middle 
after I reordered the series. Then I was under the impression that it 
was included when I tested the code. Really sorry for causing the 
trouble. I will be more careful.

I'll fix up and resend the rest of the series. Sorry for the noise.

Thanks,
Tao




  reply	other threads:[~2013-12-03 17:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 14:41 [PATCH 0/9] staging/lustre: minor cleanups and CONFIG_PROC_FS fix up Peng Tao
2013-12-03 14:41 ` [PATCH 1/9] staging/lustre/obdclass: fix false used uninitialized warning Peng Tao
2013-12-03 14:41 ` [PATCH 2/9] staging/lustre/obdclass: lprocfs_{alloc_stats,register} always defined Peng Tao
2013-12-03 14:42 ` Peng Tao
2013-12-03 14:42 ` [PATCH 3/9] staging/lustre/ldlm: inline ldlm_proc_setup Peng Tao
2013-12-03 14:42 ` [PATCH 4/9] staging/lustre/obdclass: move obd_sysctl_init out of class_procfs_init Peng Tao
2013-12-03 14:42 ` Peng Tao
2013-12-03 14:42 ` [PATCH 5/9] staging/lustre: fix defined not used warning Peng Tao
2013-12-03 14:42 ` [PATCH 6/9] staging/lustre/llite: fix used uninitialized warning Peng Tao
2013-12-03 14:42 ` [PATCH 7/9] staging/lustre/llite: remove ll_file_get_iov_count Peng Tao
2013-12-03 17:00   ` Greg Kroah-Hartman
2013-12-03 17:26     ` Peng Tao [this message]
2013-12-03 14:42 ` [PATCH 8/9] staging/lustre: fix undefined reference if CONFIG_PROC_FS is off Peng Tao
2013-12-03 14:42 ` Peng Tao
2013-12-03 14:42 ` [PATCH 9/9] staging/lustre: don't compile procfs code when " Peng Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529E1447.5070903@gmail.com \
    --to=bergwolf@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.