From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants Date: Tue, 03 Dec 2013 13:06:42 -0700 Message-ID: <529E39D2.9000705@wwwdotorg.org> References: <1385992502-12771-1-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385992502-12771-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan , rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org Cc: pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 12/02/2013 06:55 AM, Laxman Dewangan wrote: > Defines pincontrol constants to use from Tegra's DTS file > for tegra pincontrol properties option. > diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h > +/* Pull up/down/normal */ > +#define TEGRA_PIN_PUPD_NORMAL 0 > +#define TEGRA_PIN_PUPD_PULL_DOWN 1 > +#define TEGRA_PIN_PUPD_PULL_UP 2 ... and s/NORMAL/NONE/ here too, I think. Some people might consider some other value e.g. pull-up as normal:-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 03 Dec 2013 13:06:42 -0700 Subject: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants In-Reply-To: <1385992502-12771-1-git-send-email-ldewangan@nvidia.com> References: <1385992502-12771-1-git-send-email-ldewangan@nvidia.com> Message-ID: <529E39D2.9000705@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/02/2013 06:55 AM, Laxman Dewangan wrote: > Defines pincontrol constants to use from Tegra's DTS file > for tegra pincontrol properties option. > diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h > +/* Pull up/down/normal */ > +#define TEGRA_PIN_PUPD_NORMAL 0 > +#define TEGRA_PIN_PUPD_PULL_DOWN 1 > +#define TEGRA_PIN_PUPD_PULL_UP 2 ... and s/NORMAL/NONE/ here too, I think. Some people might consider some other value e.g. pull-up as normal:-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755095Ab3LCUGs (ORCPT ); Tue, 3 Dec 2013 15:06:48 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:41320 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753780Ab3LCUGq (ORCPT ); Tue, 3 Dec 2013 15:06:46 -0500 Message-ID: <529E39D2.9000705@wwwdotorg.org> Date: Tue, 03 Dec 2013 13:06:42 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Laxman Dewangan , rob.herring@calxeda.com CC: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk, thierry.reding@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: dts: tegra: Header file for pinctrl constants References: <1385992502-12771-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1385992502-12771-1-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/2013 06:55 AM, Laxman Dewangan wrote: > Defines pincontrol constants to use from Tegra's DTS file > for tegra pincontrol properties option. > diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h > +/* Pull up/down/normal */ > +#define TEGRA_PIN_PUPD_NORMAL 0 > +#define TEGRA_PIN_PUPD_PULL_DOWN 1 > +#define TEGRA_PIN_PUPD_PULL_UP 2 ... and s/NORMAL/NONE/ here too, I think. Some people might consider some other value e.g. pull-up as normal:-)