All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Regression due to 0c44c2d0f459 x86: Use asm goto to implement better modify_and_test() functions
Date: Tue, 03 Dec 2013 17:36:25 -0800	[thread overview]
Message-ID: <529E8719.4070202@zytor.com> (raw)

Hi guys,

0c44c2d0f459 x86: Use asm goto to implement better modify_and_test()
functions

causes a regression, because it incorrectly changed the constraints of
bitops.

Specifically, the GEN_BINARY_RMWcc() hardcodes a constraint as "er", but
it needs to be "Ir" for the bitops themselves.  "I" is correct (as
opposed to "J" even on 64 bits, because we only generate the 64-bit
version when we have a register operand.

Unfortunately there isn't a way we can get gcc+gas to generate a version
with an offset pointer.

	-hpa



             reply	other threads:[~2013-12-04  1:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04  1:36 H. Peter Anvin [this message]
2013-12-04  8:59 ` Regression due to 0c44c2d0f459 x86: Use asm goto to implement better modify_and_test() functions Ingo Molnar
2013-12-04 16:44   ` H. Peter Anvin
2014-01-31 21:32     ` Alex Williamson
2013-12-04 22:51 ` [tip:x86/urgent] x86, bitops: Correct the assembly constraints to testing bitops tip-bot for H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529E8719.4070202@zytor.com \
    --to=hpa@zytor.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.