From: Subho Banerjee <ssbanerje@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Michael Petlan <mpetlan@redhat.com>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf vendor events: Make the power8/power9 event files valid JSON
Date: Mon, 18 Nov 2019 21:21:07 -0600 [thread overview]
Message-ID: <529EC552-AF92-45FD-9043-AB5A570B29AD@gmail.com> (raw)
In-Reply-To: <E980D3B0-4519-451C-A0D7-7A8CE1A5AB2C@gmail.com>
Hi Arnaldo,
I am uncertain which commit you are working on.
The command that you sent fails on the latest commit of the master branch (af42d3466bdc8f39806b26f593604fdc54140bcb) on kernel/git/torvalds/linux.git.
Is there a more up to date version of the perf tools that I should be looking at instead of what is in the kernel repo?
ssbaner2@dvorak:~/linux$ git rev-parse --verify HEAD
af42d3466bdc8f39806b26f593604fdc54140bcb
ssbaner2@dvorak:~/linux$ diffstat -l -p1 0001-perf-vendor-events-Make-the-power8-power9-event-file.patch | while read filename ; do echo $filename ; cat $filename | json_verify ; done
tools/perf/pmu-events/arch/powerpc/power8/cache.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x4c0
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/floating-point.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x200
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/frontend.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x250
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/marked.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x351
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/memory.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x100
(right here) ------^
JSON is invalid
tools/perf/pmu-events/arch/powerpc/power8/other.json
parse error: invalid object key (must be a string)
[ {, "EventCode": "0x1f0
(right here) ------^
JSON is invalid
Regards,
Subho
> On Nov 18, 2019, at 9:18 PM, Subho Banerjee <ssbanerje@gmail.com> wrote:
>
> Hi Arnaldo,
> I am uncertain which commit you are working on.
>
> The command that you sent fails on the latest commit of the master branch (af42d3466bdc8f39806b26f593604fdc54140bcb) on kernel/git/torvalds/linux.git.
>
> Is there a more up to date version of the perf tools that I should be looking at instead of what is in the kernel repo?
>
> ssbaner2@dvorak:~/linux$ git rev-parse --verify HEAD
> af42d3466bdc8f39806b26f593604fdc54140bcb
>
>
> ssbaner2@dvorak:~/linux$ diffstat -l -p1 0001-perf-vendor-events-Make-the-power8-power9-event-file.patch | while read filename ; do echo $filename ; cat $filename | json_verify ; done
> tools/perf/pmu-events/arch/powerpc/power8/cache.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x4c0
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/floating-point.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x200
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/frontend.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x250
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/marked.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x351
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/memory.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x100
> (right here) ------^
> JSON is invalid
> tools/perf/pmu-events/arch/powerpc/power8/other.json
> parse error: invalid object key (must be a string)
> [ {, "EventCode": "0x1f0
> (right here) ------^
> JSON is invalid
>
>
> Regards,
> Subho
next prev parent reply other threads:[~2019-11-19 3:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 23:15 [PATCH] perf vendor events: Make the power8/power9 event files valid JSON ssbanerje
2019-11-18 22:13 ` Arnaldo Carvalho de Melo
[not found] ` <E980D3B0-4519-451C-A0D7-7A8CE1A5AB2C@gmail.com>
2019-11-19 3:21 ` Subho Banerjee [this message]
2019-11-19 3:23 ` Ravi Bangoria
2019-11-19 10:58 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529EC552-AF92-45FD-9043-AB5A570B29AD@gmail.com \
--to=ssbanerje@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mamatha4@linux.vnet.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.