All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm: mmp: build sram driver alone
@ 2013-12-04  7:05 Qiao Zhou
  2013-12-04  7:05 ` [PATCH 2/2] dma: mmp-tdma: select sram driver Qiao Zhou
  2013-12-04  7:56 ` [PATCH 1/2] arm: mmp: build sram driver alone Dan Williams
  0 siblings, 2 replies; 5+ messages in thread
From: Qiao Zhou @ 2013-12-04  7:05 UTC (permalink / raw)
  To: eric.y.miao, haojian.zhuang, dan.j.williams, vinod.koul,
	linux-kernel, dmaengine, chao.xie
  Cc: Qiao Zhou

sram driver can be used by many chips besides CPU_MMP2, and so build
it alone.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
 arch/arm/mach-mmp/Kconfig  |    5 +++++
 arch/arm/mach-mmp/Makefile |    3 ++-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index ebdda83..6a6597c 100644
--- a/arch/arm/mach-mmp/Kconfig
+++ b/arch/arm/mach-mmp/Kconfig
@@ -136,4 +136,9 @@ config USB_EHCI_MV_U2O
 	help
 	  Enables support for OTG controller which can be switched to host mode.
 
+config MMP_SRAM
+	bool
+	help
+	  Select code specific to sram.
+
 endif
diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
index 9b702a1..98f0f63 100644
--- a/arch/arm/mach-mmp/Makefile
+++ b/arch/arm/mach-mmp/Makefile
@@ -7,7 +7,8 @@ obj-y				+= common.o devices.o time.o
 # SoC support
 obj-$(CONFIG_CPU_PXA168)	+= pxa168.o
 obj-$(CONFIG_CPU_PXA910)	+= pxa910.o
-obj-$(CONFIG_CPU_MMP2)		+= mmp2.o sram.o
+obj-$(CONFIG_CPU_MMP2)		+= mmp2.o
+obj-$(CONFIG_MMP_SRAM)		+= sram.o
 
 ifeq ($(CONFIG_COMMON_CLK), )
 obj-y				+= clock.o
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dma: mmp-tdma: select sram driver
  2013-12-04  7:05 [PATCH 1/2] arm: mmp: build sram driver alone Qiao Zhou
@ 2013-12-04  7:05 ` Qiao Zhou
  2013-12-04  7:56 ` [PATCH 1/2] arm: mmp: build sram driver alone Dan Williams
  1 sibling, 0 replies; 5+ messages in thread
From: Qiao Zhou @ 2013-12-04  7:05 UTC (permalink / raw)
  To: eric.y.miao, haojian.zhuang, dan.j.williams, vinod.koul,
	linux-kernel, dmaengine, chao.xie
  Cc: Qiao Zhou

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
 drivers/dma/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index dd2874e..4e41b69 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -288,6 +288,7 @@ config MMP_TDMA
 	bool "MMP Two-Channel DMA support"
 	depends on ARCH_MMP
 	select DMA_ENGINE
+	select MMP_SRAM
 	help
 	  Support the MMP Two-Channel DMA engine.
 	  This engine used for MMP Audio DMA and pxa910 SQU.
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm: mmp: build sram driver alone
  2013-12-04  7:05 [PATCH 1/2] arm: mmp: build sram driver alone Qiao Zhou
  2013-12-04  7:05 ` [PATCH 2/2] dma: mmp-tdma: select sram driver Qiao Zhou
@ 2013-12-04  7:56 ` Dan Williams
  2013-12-04  8:01   ` Qiao Zhou
  1 sibling, 1 reply; 5+ messages in thread
From: Dan Williams @ 2013-12-04  7:56 UTC (permalink / raw)
  To: Qiao Zhou
  Cc: eric.y.miao, Haojian Zhuang, Vinod Koul,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, chao.xie

On Tue, Dec 3, 2013 at 11:05 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
> sram driver can be used by many chips besides CPU_MMP2, and so build
> it alone.
>
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
> ---
>  arch/arm/mach-mmp/Kconfig  |    5 +++++
>  arch/arm/mach-mmp/Makefile |    3 ++-
>  2 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> index ebdda83..6a6597c 100644
> --- a/arch/arm/mach-mmp/Kconfig
> +++ b/arch/arm/mach-mmp/Kconfig
> @@ -136,4 +136,9 @@ config USB_EHCI_MV_U2O
>         help
>           Enables support for OTG controller which can be switched to host mode.
>
> +config MMP_SRAM
> +       bool
> +       help
> +         Select code specific to sram.
> +

No need for help text for something that is selected, and might as
well squash this with patch 2.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm: mmp: build sram driver alone
  2013-12-04  7:56 ` [PATCH 1/2] arm: mmp: build sram driver alone Dan Williams
@ 2013-12-04  8:01   ` Qiao Zhou
  0 siblings, 0 replies; 5+ messages in thread
From: Qiao Zhou @ 2013-12-04  8:01 UTC (permalink / raw)
  To: Dan Williams
  Cc: eric.y.miao@gmail.com, Haojian Zhuang, Vinod Koul,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Chao Xie

On 12/04/2013 03:56 PM, Dan Williams wrote:
> On Tue, Dec 3, 2013 at 11:05 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
>> sram driver can be used by many chips besides CPU_MMP2, and so build
>> it alone.
>>
>> Reported-by: Dan Williams <dan.j.williams@intel.com>
>> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
>> ---
>>   arch/arm/mach-mmp/Kconfig  |    5 +++++
>>   arch/arm/mach-mmp/Makefile |    3 ++-
>>   2 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
>> index ebdda83..6a6597c 100644
>> --- a/arch/arm/mach-mmp/Kconfig
>> +++ b/arch/arm/mach-mmp/Kconfig
>> @@ -136,4 +136,9 @@ config USB_EHCI_MV_U2O
>>          help
>>            Enables support for OTG controller which can be switched to host mode.
>>
>> +config MMP_SRAM
>> +       bool
>> +       help
>> +         Select code specific to sram.
>> +
>
> No need for help text for something that is selected, and might as
> well squash this with patch 2.
>
Dan, thanks. I'll update it.

-- 

Best Regards
Qiao

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] arm: mmp: build sram driver alone
  2013-12-04  8:21 [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone Qiao Zhou
@ 2013-12-04  8:21 ` Qiao Zhou
  0 siblings, 0 replies; 5+ messages in thread
From: Qiao Zhou @ 2013-12-04  8:21 UTC (permalink / raw)
  To: eric.y.miao, haojian.zhuang, dan.j.williams, vinod.koul,
	linux-kernel, dmaengine, chao.xie
  Cc: Qiao Zhou

sram driver can be used by many chips besides CPU_MMP2, and so build
it alone.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
 arch/arm/mach-mmp/Kconfig  |    3 +++
 arch/arm/mach-mmp/Makefile |    3 ++-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index ebdda83..ebdba87 100644
--- a/arch/arm/mach-mmp/Kconfig
+++ b/arch/arm/mach-mmp/Kconfig
@@ -136,4 +136,7 @@ config USB_EHCI_MV_U2O
 	help
 	  Enables support for OTG controller which can be switched to host mode.
 
+config MMP_SRAM
+	bool
+
 endif
diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
index 9b702a1..98f0f63 100644
--- a/arch/arm/mach-mmp/Makefile
+++ b/arch/arm/mach-mmp/Makefile
@@ -7,7 +7,8 @@ obj-y				+= common.o devices.o time.o
 # SoC support
 obj-$(CONFIG_CPU_PXA168)	+= pxa168.o
 obj-$(CONFIG_CPU_PXA910)	+= pxa910.o
-obj-$(CONFIG_CPU_MMP2)		+= mmp2.o sram.o
+obj-$(CONFIG_CPU_MMP2)		+= mmp2.o
+obj-$(CONFIG_MMP_SRAM)		+= sram.o
 
 ifeq ($(CONFIG_COMMON_CLK), )
 obj-y				+= clock.o
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-12-04  8:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-04  7:05 [PATCH 1/2] arm: mmp: build sram driver alone Qiao Zhou
2013-12-04  7:05 ` [PATCH 2/2] dma: mmp-tdma: select sram driver Qiao Zhou
2013-12-04  7:56 ` [PATCH 1/2] arm: mmp: build sram driver alone Dan Williams
2013-12-04  8:01   ` Qiao Zhou
  -- strict thread matches above, loose matches on Subject: below --
2013-12-04  8:21 [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone Qiao Zhou
2013-12-04  8:21 ` [PATCH 1/2] arm: mmp: build sram driver alone Qiao Zhou

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.