From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Schinagl Subject: Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs Date: Wed, 04 Dec 2013 13:49:59 +0100 Message-ID: <529F24F7.40309@schinagl.nl> References: <1386159055-10264-1-git-send-email-oliver@schinagl.nl> <1386159055-10264-3-git-send-email-oliver@schinagl.nl> <20131204122602.GN16025@e106331-lin.cambridge.arm.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Return-path: In-Reply-To: <20131204122602.GN16025-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Mark Rutland Cc: "tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org" , "maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" , "ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "oliver+list-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org" List-Id: linux-ide@vger.kernel.org On 04-12-13 13:26, Mark Rutland wrote: > On Wed, Dec 04, 2013 at 12:10:54PM +0000, oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org wrote: >> From: Oliver Schinagl >> >> This patch adds support for the sunxi series of SoC's by allwinner. It >> plugs into the ahci-platform framework. >> >> Note: Currently it uses a somewhat hackish approach that probably needs >> a lot more work, but does the same as the IMX SoC's. >> >> Signed-off-by: Olliver Schinagl >> --- >> .../devicetree/bindings/ata/ahci-sunxi.txt | 24 ++ >> drivers/ata/Kconfig | 9 + >> drivers/ata/Makefile | 1 + >> drivers/ata/ahci_platform.c | 12 + >> drivers/ata/ahci_sunxi.c | 305 +++++++++++++++++++++ >> 5 files changed, 351 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/ata/ahci-sunxi.txt >> create mode 100644 drivers/ata/ahci_sunxi.c >> >> diff --git a/Documentation/devicetree/bindings/ata/ahci-sunxi.txt b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt >> new file mode 100644 >> index 0000000..0792fa5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt >> @@ -0,0 +1,24 @@ >> +Allwinner SUNXI AHCI SATA Controller >> + >> +SATA nodes are defined to describe on-chip Serial ATA controllers. >> +Each SATA controller should have its own node. >> + >> +Required properties: >> +- compatible : compatible list, contains "allwinner,sun4i-a10-ahci" > - compatible: Should contain "allwinner,sun4i-a10-ahci" > >> +- reg : > - reg: The offset and length of the MMIO registers. > >> +- interrupts : > - interrupts: An interrupt-specifier for the ACHI interrupt > >> +- clocks : clocks for ACHI >> +- clock-names : clock names for AHCI > Please _define_ the set of clock-names you expect. This binding is > meaningless without it. If you require clock-names, define the clocks > property in terms of it. I copied ahci_platform.txt and filled in the missing bits, I will improve all the above. Appologies! > > Thanks, > Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932403Ab3LDMv1 (ORCPT ); Wed, 4 Dec 2013 07:51:27 -0500 Received: from 7of9.schinagl.nl ([88.159.158.68]:33895 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932184Ab3LDMvZ (ORCPT ); Wed, 4 Dec 2013 07:51:25 -0500 Message-ID: <529F24F7.40309@schinagl.nl> Date: Wed, 04 Dec 2013 13:49:59 +0100 From: Oliver Schinagl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Mark Rutland CC: "tj@kernel.org" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "dev@linux-sunxi.org" , "maxime.ripard@free-electrons.com" , "ijc@hellion.org.uk" , "hdegoede@redhat.com" , "oliver+list@schinagl.nl" Subject: Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs References: <1386159055-10264-1-git-send-email-oliver@schinagl.nl> <1386159055-10264-3-git-send-email-oliver@schinagl.nl> <20131204122602.GN16025@e106331-lin.cambridge.arm.com> In-Reply-To: <20131204122602.GN16025@e106331-lin.cambridge.arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04-12-13 13:26, Mark Rutland wrote: > On Wed, Dec 04, 2013 at 12:10:54PM +0000, oliver@schinagl.nl wrote: >> From: Oliver Schinagl >> >> This patch adds support for the sunxi series of SoC's by allwinner. It >> plugs into the ahci-platform framework. >> >> Note: Currently it uses a somewhat hackish approach that probably needs >> a lot more work, but does the same as the IMX SoC's. >> >> Signed-off-by: Olliver Schinagl >> --- >> .../devicetree/bindings/ata/ahci-sunxi.txt | 24 ++ >> drivers/ata/Kconfig | 9 + >> drivers/ata/Makefile | 1 + >> drivers/ata/ahci_platform.c | 12 + >> drivers/ata/ahci_sunxi.c | 305 +++++++++++++++++++++ >> 5 files changed, 351 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/ata/ahci-sunxi.txt >> create mode 100644 drivers/ata/ahci_sunxi.c >> >> diff --git a/Documentation/devicetree/bindings/ata/ahci-sunxi.txt b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt >> new file mode 100644 >> index 0000000..0792fa5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt >> @@ -0,0 +1,24 @@ >> +Allwinner SUNXI AHCI SATA Controller >> + >> +SATA nodes are defined to describe on-chip Serial ATA controllers. >> +Each SATA controller should have its own node. >> + >> +Required properties: >> +- compatible : compatible list, contains "allwinner,sun4i-a10-ahci" > - compatible: Should contain "allwinner,sun4i-a10-ahci" > >> +- reg : > - reg: The offset and length of the MMIO registers. > >> +- interrupts : > - interrupts: An interrupt-specifier for the ACHI interrupt > >> +- clocks : clocks for ACHI >> +- clock-names : clock names for AHCI > Please _define_ the set of clock-names you expect. This binding is > meaningless without it. If you require clock-names, define the clocks > property in terms of it. I copied ahci_platform.txt and filled in the missing bits, I will improve all the above. Appologies! > > Thanks, > Mark.