From: alex.elder@linaro.org (Alex Elder)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: bcm281xx: define kona clock binding
Date: Wed, 04 Dec 2013 10:24:00 -0600 [thread overview]
Message-ID: <529F5720.5040601@linaro.org> (raw)
In-Reply-To: <529F23EC.20306@linaro.org>
On 12/04/2013 06:45 AM, Alex Elder wrote:
>>> +Device tree example:
>>> >> +
>>> >> + clocks {
>>> >> + slave_ccu: slave_ccu {
>>> >> + compatible = "brcm,bcm11351-slave-ccu";
>>> >> + reg = <0x3e011000 0x0f00>;
>>> >> + #clock-cells = <1>;
>>> >> + clock-output-names = "uartb",
>>> >> + "uartb2",
>>> >> + "uartb3",
>>> >> + "uartb4";
>>> >> + };
>>> >> + ref_crystal_clk: ref_crystal {
>>> >> + #clock-cells = <0>;
>>> >> + compatible = "fixed-clock";
>>> >> + clock-frequency = <26000000>;
>>> >> + };
>>> >> + };
>> >
>> > This is wrong, as the clocks container node us not defined as any type
>> > of bus, and does not have the requisite #address-cells and #size-cells.
> Sorry, I didn't realize it was wrong. I intentionally used
> it simply for groiuping.
I should have looked at my actual dtsi file before responding.
It turns out that what was shown there was not complete. The
dtsi file in fact does contain #address-cells and #size-cells
(and a direct-mapping "ranges" property).
I have removed the enclosing "clocks" node and its braces in
the document. I have not removed the node from the dtsi file.
-Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <alex.elder@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Christian Daudt <bcm@fixthebug.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Pawel Moll <Pawel.Moll@arm.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Stephen Warren <swarren@wwwdotorg.org>,
Mike Turquette <mturquette@linaro.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] clk: bcm281xx: define kona clock binding
Date: Wed, 04 Dec 2013 10:24:00 -0600 [thread overview]
Message-ID: <529F5720.5040601@linaro.org> (raw)
In-Reply-To: <529F23EC.20306@linaro.org>
On 12/04/2013 06:45 AM, Alex Elder wrote:
>>> +Device tree example:
>>> >> +
>>> >> + clocks {
>>> >> + slave_ccu: slave_ccu {
>>> >> + compatible = "brcm,bcm11351-slave-ccu";
>>> >> + reg = <0x3e011000 0x0f00>;
>>> >> + #clock-cells = <1>;
>>> >> + clock-output-names = "uartb",
>>> >> + "uartb2",
>>> >> + "uartb3",
>>> >> + "uartb4";
>>> >> + };
>>> >> + ref_crystal_clk: ref_crystal {
>>> >> + #clock-cells = <0>;
>>> >> + compatible = "fixed-clock";
>>> >> + clock-frequency = <26000000>;
>>> >> + };
>>> >> + };
>> >
>> > This is wrong, as the clocks container node us not defined as any type
>> > of bus, and does not have the requisite #address-cells and #size-cells.
> Sorry, I didn't realize it was wrong. I intentionally used
> it simply for groiuping.
I should have looked at my actual dtsi file before responding.
It turns out that what was shown there was not complete. The
dtsi file in fact does contain #address-cells and #size-cells
(and a direct-mapping "ranges" property).
I have removed the enclosing "clocks" node and its braces in
the document. I have not removed the node from the dtsi file.
-Alex
next prev parent reply other threads:[~2013-12-04 16:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 3:54 [PATCH 0/3] clk: bcm281xx: define Broadcom kona clocks Alex Elder
2013-12-04 3:54 ` Alex Elder
2013-12-04 3:56 ` [PATCH 1/3] clk: bcm281xx: define kona clock binding Alex Elder
2013-12-04 3:56 ` Alex Elder
2013-12-04 9:39 ` Mark Rutland
2013-12-04 9:39 ` Mark Rutland
2013-12-04 12:45 ` Alex Elder
2013-12-04 12:45 ` Alex Elder
2013-12-04 16:24 ` Alex Elder [this message]
2013-12-04 16:24 ` Alex Elder
2013-12-04 3:57 ` [PATCH 2/3] clk: bcm281xx: add initial clock framework support Alex Elder
2013-12-04 3:57 ` Alex Elder
2013-12-04 11:14 ` Mark Rutland
2013-12-04 11:14 ` Mark Rutland
2013-12-04 13:06 ` Alex Elder
2013-12-04 13:06 ` Alex Elder
2013-12-04 13:57 ` Alex Elder
2013-12-04 13:57 ` Alex Elder
2013-12-04 14:09 ` Mark Rutland
2013-12-04 14:09 ` Mark Rutland
2013-12-04 3:57 ` [PATCH 3/3] ARM: dts: bcm281xx: define real clocks Alex Elder
2013-12-04 3:57 ` Alex Elder
2013-12-04 11:19 ` Mark Rutland
2013-12-04 11:19 ` Mark Rutland
2013-12-04 13:19 ` Alex Elder
2013-12-04 13:19 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F5720.5040601@linaro.org \
--to=alex.elder@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.