From: Andrew Cooper <andrew.cooper3@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>, Tim Deegan <tim@xen.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] coverity: Store the modelling file in the source tree.
Date: Wed, 4 Dec 2013 16:33:47 +0000 [thread overview]
Message-ID: <529F596B.2060808@citrix.com> (raw)
In-Reply-To: <529F543E.8060407@citrix.com>
On 04/12/13 16:11, David Vrabel wrote:
> On 04/12/13 15:29, Andrew Cooper wrote:
>> +/*
>> + * unmap_domain_page() will correctly unmap the page, given any virtual
>> + * address inside the page.
> I think the va must be page aligned? Or am I getting mixed up with the
> requirement for map_domain_page_global()?
>
> David
unmap_domain_page() uses PFN_DOWN(va), which discards the bottom 12 bits.
unmap_domain_page_global() passes off to vunmap() which does appear to
want an aligned pointer.
~Andrew
prev parent reply other threads:[~2013-12-04 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 15:29 [PATCH] coverity: Store the modelling file in the source tree Andrew Cooper
2013-12-04 15:37 ` Tim Deegan
2013-12-04 15:48 ` Andrew Cooper
2013-12-04 15:54 ` Tim Deegan
2013-12-04 16:11 ` David Vrabel
2013-12-04 16:33 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F596B.2060808@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.