From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org
Cc: pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants
Date: Wed, 04 Dec 2013 10:03:32 -0700 [thread overview]
Message-ID: <529F6064.3010300@wwwdotorg.org> (raw)
In-Reply-To: <1386076567-14283-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 12/03/2013 06:16 AM, Laxman Dewangan wrote:
> This new header file defines pincontrol constants for Tegra to
> use from Tegra's DTS file for pincontrol properties option.
> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> +#define TEGRA_PIN_DISABLE 0
> +#define TEGRA_PIN_ENABLE 1
That needs a comment re: which properties the defines can be used with,
since the properties are no longer related to the defines by name.
> +/* Pull up/down/normal */
> +#define TEGRA_PIN_PULL_NONE 0
> +#define TEGRA_PIN_PULL_DOWN 1
> +#define TEGRA_PIN_PULL_UP 2
Whereas that comment seems unnecessary, since it's obvious from the
define names.
> +/* Low power mode */
> +#define TEGRA_PIN_LP_DRIVE_DIV_8 0
> +#define TEGRA_PIN_LP_DRIVE_DIV_4 1
> +#define TEGRA_PIN_LP_DRIVE_DIV_2 2
> +#define TEGRA_PIN_LP_DRIVE_DIV_1 3
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants
Date: Wed, 04 Dec 2013 10:03:32 -0700 [thread overview]
Message-ID: <529F6064.3010300@wwwdotorg.org> (raw)
In-Reply-To: <1386076567-14283-1-git-send-email-ldewangan@nvidia.com>
On 12/03/2013 06:16 AM, Laxman Dewangan wrote:
> This new header file defines pincontrol constants for Tegra to
> use from Tegra's DTS file for pincontrol properties option.
> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> +#define TEGRA_PIN_DISABLE 0
> +#define TEGRA_PIN_ENABLE 1
That needs a comment re: which properties the defines can be used with,
since the properties are no longer related to the defines by name.
> +/* Pull up/down/normal */
> +#define TEGRA_PIN_PULL_NONE 0
> +#define TEGRA_PIN_PULL_DOWN 1
> +#define TEGRA_PIN_PULL_UP 2
Whereas that comment seems unnecessary, since it's obvious from the
define names.
> +/* Low power mode */
> +#define TEGRA_PIN_LP_DRIVE_DIV_8 0
> +#define TEGRA_PIN_LP_DRIVE_DIV_4 1
> +#define TEGRA_PIN_LP_DRIVE_DIV_2 2
> +#define TEGRA_PIN_LP_DRIVE_DIV_1 3
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>, rob.herring@calxeda.com
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk,
thierry.reding@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants
Date: Wed, 04 Dec 2013 10:03:32 -0700 [thread overview]
Message-ID: <529F6064.3010300@wwwdotorg.org> (raw)
In-Reply-To: <1386076567-14283-1-git-send-email-ldewangan@nvidia.com>
On 12/03/2013 06:16 AM, Laxman Dewangan wrote:
> This new header file defines pincontrol constants for Tegra to
> use from Tegra's DTS file for pincontrol properties option.
> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h
> +#define TEGRA_PIN_DISABLE 0
> +#define TEGRA_PIN_ENABLE 1
That needs a comment re: which properties the defines can be used with,
since the properties are no longer related to the defines by name.
> +/* Pull up/down/normal */
> +#define TEGRA_PIN_PULL_NONE 0
> +#define TEGRA_PIN_PULL_DOWN 1
> +#define TEGRA_PIN_PULL_UP 2
Whereas that comment seems unnecessary, since it's obvious from the
define names.
> +/* Low power mode */
> +#define TEGRA_PIN_LP_DRIVE_DIV_8 0
> +#define TEGRA_PIN_LP_DRIVE_DIV_4 1
> +#define TEGRA_PIN_LP_DRIVE_DIV_2 2
> +#define TEGRA_PIN_LP_DRIVE_DIV_1 3
next prev parent reply other threads:[~2013-12-04 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 13:16 [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants Laxman Dewangan
2013-12-03 13:16 ` Laxman Dewangan
2013-12-03 13:16 ` Laxman Dewangan
2013-12-03 13:16 ` [PATCH V2 2/2] ARM: tegra: convert device tree file of Dalmore to use pinctrl defines Laxman Dewangan
2013-12-03 13:16 ` Laxman Dewangan
2013-12-03 13:16 ` Laxman Dewangan
[not found] ` <1386076567-14283-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-04 17:03 ` Stephen Warren
2013-12-04 17:03 ` Stephen Warren
2013-12-04 17:03 ` Stephen Warren
2013-12-04 8:20 ` [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants Thierry Reding
2013-12-04 8:20 ` Thierry Reding
[not found] ` <1386076567-14283-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-04 17:03 ` Stephen Warren [this message]
2013-12-04 17:03 ` Stephen Warren
2013-12-04 17:03 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F6064.3010300@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.