From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools: libxl: testidl: initialise the KeyedUnion keyvar before the union Date: Wed, 4 Dec 2013 17:54:22 +0000 Message-ID: <529F6C4E.30606@citrix.com> References: <529F663A.4030604@citrix.com> <1386179336-2829-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386179336-2829-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/12/13 17:48, Ian Campbell wrote: > This is Coverity CID 1135378 and 1135379. > > Signed-off-by: Ian Campbell > Cc: Andrew Cooper This sound plausible, although given my unfamiliarity with gentest.py, I dont feel as if a Reviewed-by tag is appropriate. ~Andrew > --- > tools/libxl/gentest.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/libxl/gentest.py b/tools/libxl/gentest.py > index 6fab493..722b7f4 100644 > --- a/tools/libxl/gentest.py > +++ b/tools/libxl/gentest.py > @@ -42,6 +42,7 @@ def gen_rand_init(ty, v, indent = " ", parent = None): > elif isinstance(ty, idl.KeyedUnion): > if parent is None: > raise Exception("KeyedUnion type must have a parent") > + s += gen_rand_init(ty.keyvar.type, parent + ty.keyvar.name, indent, parent) > s += "switch (%s) {\n" % (parent + ty.keyvar.name) > for f in ty.fields: > (nparent,fexpr) = ty.member(v, f, parent is None)