From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com ([198.47.26.152]:58322 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752934Ab3LDSFj (ORCPT ); Wed, 4 Dec 2013 13:05:39 -0500 Message-ID: <529F6EBE.5050703@ti.com> Date: Wed, 4 Dec 2013 23:34:46 +0530 From: Sekhar Nori MIME-Version: 1.0 To: Ivan Khoronzhuk CC: Santosh Shilimkar , , , , , , , , , , , , , Subject: Re: [PATCH v4 1/5] watchdog: davinci: change driver to use WDT core References: <1385556508-3935-1-git-send-email-ivan.khoronzhuk@ti.com> <1385556508-3935-2-git-send-email-ivan.khoronzhuk@ti.com> In-Reply-To: <1385556508-3935-2-git-send-email-ivan.khoronzhuk@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 11/27/2013 6:18 PM, Ivan Khoronzhuk wrote: > To reduce code duplicate and increase code readability use WDT core > code to handle WDT interface. > > Remove io_lock as the WDT core uses mutex to lock each wdt device. > Remove wdt_state as the WDT core tracks state with its own variable. > > The watchdog_init_timeout() can read timeout value from timeout-sec > property if the passed value is out of bounds. The heartbeat is > initialized in next way. If heartbeat is not set thought module > parameter, try to read it's value from WDT node timeout-sec property. > If node has no one, use default value. > > The heartbeat is hold in wdd->timeout by WDT core, so use it in > order to set timeout period. > > Acked-by: Santosh Shilimkar > Reviewed-by: Guenter Roeck > Signed-off-by: Ivan Khoronzhuk > --- > drivers/watchdog/Kconfig | 2 + > drivers/watchdog/davinci_wdt.c | 147 ++++++++++------------------------------ > 2 files changed, 37 insertions(+), 112 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 5be6e91..eb8c89d 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -271,6 +271,8 @@ config IOP_WATCHDOG > config DAVINCI_WATCHDOG > tristate "DaVinci watchdog" > depends on ARCH_DAVINCI > + select WATCHDOG_CORE > + select WATCHDOG_NOWAYOUT Its not clear for change log why NOWAYOUT needs to be forced on all the time for all users of DaVinci watchdog. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Wed, 4 Dec 2013 23:34:46 +0530 Subject: [PATCH v4 1/5] watchdog: davinci: change driver to use WDT core In-Reply-To: <1385556508-3935-2-git-send-email-ivan.khoronzhuk@ti.com> References: <1385556508-3935-1-git-send-email-ivan.khoronzhuk@ti.com> <1385556508-3935-2-git-send-email-ivan.khoronzhuk@ti.com> Message-ID: <529F6EBE.5050703@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/27/2013 6:18 PM, Ivan Khoronzhuk wrote: > To reduce code duplicate and increase code readability use WDT core > code to handle WDT interface. > > Remove io_lock as the WDT core uses mutex to lock each wdt device. > Remove wdt_state as the WDT core tracks state with its own variable. > > The watchdog_init_timeout() can read timeout value from timeout-sec > property if the passed value is out of bounds. The heartbeat is > initialized in next way. If heartbeat is not set thought module > parameter, try to read it's value from WDT node timeout-sec property. > If node has no one, use default value. > > The heartbeat is hold in wdd->timeout by WDT core, so use it in > order to set timeout period. > > Acked-by: Santosh Shilimkar > Reviewed-by: Guenter Roeck > Signed-off-by: Ivan Khoronzhuk > --- > drivers/watchdog/Kconfig | 2 + > drivers/watchdog/davinci_wdt.c | 147 ++++++++++------------------------------ > 2 files changed, 37 insertions(+), 112 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 5be6e91..eb8c89d 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -271,6 +271,8 @@ config IOP_WATCHDOG > config DAVINCI_WATCHDOG > tristate "DaVinci watchdog" > depends on ARCH_DAVINCI > + select WATCHDOG_CORE > + select WATCHDOG_NOWAYOUT Its not clear for change log why NOWAYOUT needs to be forced on all the time for all users of DaVinci watchdog. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v4 1/5] watchdog: davinci: change driver to use WDT core Date: Wed, 4 Dec 2013 23:34:46 +0530 Message-ID: <529F6EBE.5050703@ti.com> References: <1385556508-3935-1-git-send-email-ivan.khoronzhuk@ti.com> <1385556508-3935-2-git-send-email-ivan.khoronzhuk@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385556508-3935-2-git-send-email-ivan.khoronzhuk@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ivan Khoronzhuk Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, linux-watchdog@vger.kernel.org, Pawel.Moll@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, galak@kernel.crashing.org, rob.herring@calxeda.com, linux-kernel@vger.kernel.org, wim@iguana.be, Santosh Shilimkar , grant.likely@linaro.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 11/27/2013 6:18 PM, Ivan Khoronzhuk wrote: > To reduce code duplicate and increase code readability use WDT core > code to handle WDT interface. > > Remove io_lock as the WDT core uses mutex to lock each wdt device. > Remove wdt_state as the WDT core tracks state with its own variable. > > The watchdog_init_timeout() can read timeout value from timeout-sec > property if the passed value is out of bounds. The heartbeat is > initialized in next way. If heartbeat is not set thought module > parameter, try to read it's value from WDT node timeout-sec property. > If node has no one, use default value. > > The heartbeat is hold in wdd->timeout by WDT core, so use it in > order to set timeout period. > > Acked-by: Santosh Shilimkar > Reviewed-by: Guenter Roeck > Signed-off-by: Ivan Khoronzhuk > --- > drivers/watchdog/Kconfig | 2 + > drivers/watchdog/davinci_wdt.c | 147 ++++++++++------------------------------ > 2 files changed, 37 insertions(+), 112 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 5be6e91..eb8c89d 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -271,6 +271,8 @@ config IOP_WATCHDOG > config DAVINCI_WATCHDOG > tristate "DaVinci watchdog" > depends on ARCH_DAVINCI > + select WATCHDOG_CORE > + select WATCHDOG_NOWAYOUT Its not clear for change log why NOWAYOUT needs to be forced on all the time for all users of DaVinci watchdog. Thanks, Sekhar