From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoH4B-0007ZM-QX for qemu-devel@nongnu.org; Wed, 04 Dec 2013 13:21:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoH45-0002QA-F7 for qemu-devel@nongnu.org; Wed, 04 Dec 2013 13:20:55 -0500 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:56166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoH45-0002PX-9F for qemu-devel@nongnu.org; Wed, 04 Dec 2013 13:20:49 -0500 Message-ID: <529F7279.70808@weilnetz.de> Date: Wed, 04 Dec 2013 19:20:41 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1385023877-26524-1-git-send-email-pl@kamp.de> <529F6CD6.30005@kamp.de> In-Reply-To: <529F6CD6.30005@kamp.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] RESEND: [PATCHv2 0/6] ui/vnc: update optimizations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: corentincj@iksaif.net, hengqing.hu@gmail.com, anthony@codemonkey.ws Am 04.12.2013 18:56, schrieb Peter Lieven: > Ping > > Am 21.11.2013 09:51, schrieb Peter Lieven: >> this series includes several optimizations for the ui/vnc guest to ser= ver and server to client >> update cycles. comments/reviews appreciated. >> >> v1->v2: - new patches 2,4,5 >> - patch3: added performance test [Anthony] >> - patch3: further optimized the vnc_update_client by searching= for the next zero bit >> with find_next_zero_bit. >> - patch3: further optimized vnc_dpy_switch by using bitmap_set= to mask bits dirty. >> >> Peter >> >> Peter Lieven (6): >> ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro >> ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT >> ui/vnc: optimize dirty bitmap tracking >> ui/vnc: optimize clearing in find_and_clear_dirty_height() >> ui/vnc: optimize setting in vnc_dpy_update() >> ui/vnc: disable adaptive update calculations if not needed >> >> ui/vnc.c | 185 ++++++++++++++++++++++++++++++++++++-----------------= --------- >> ui/vnc.h | 9 ++- >> 2 files changed, 115 insertions(+), 79 deletions(-) Hallo Peter, there was an e-mail from Eric which you might consider in a 2nd version of your patch series. Please check also your patches using scripts/checkpatch.pl. Some of them currently produce warnings: total: 0 errors, 1 warnings, 139 lines checked0001-ui-vnc-introduce-VNC_DIRTY_PIXELS_PER_BIT-macro.patch total: 0 errors, 6 warnings, 212 lines checked0003-ui-vnc-optimize-dirty-bitmap-tracking.patch total: 0 errors, 1 warnings, 17 lines checked0005-ui-vnc-optimize-setting-in-vnc_dpy_update.patch I think it would also be reasonable to fix the coding style for this code location in a separate patch before modifying the else statement, but maybe this is optional: else - w_lim =3D w - (w_lim % 16); + w_lim =3D w - (w_lim % VNC_DIRTY_PIXELS_PER_BIT); Viele Gr=FC=DFe Stefan Weil