From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] DaVinci fixes for v3.13-rc3
Date: Thu, 5 Dec 2013 04:13:35 +0530 [thread overview]
Message-ID: <529FB017.4050102@ti.com> (raw)
In-Reply-To: <CAOesGMjRHM2Ycc9_tPJwaAwL_YgJPKqa3o5vaBFreV1pA6_7Jw@mail.gmail.com>
+ Peter
Hi Olof,
On 12/5/2013 4:03 AM, Olof Johansson wrote:
> Hi,
>
> Pulled.
>
> A suggestion for the future, please try to use a patch description
> that doesn't require you to motivate why this is needed now. I.e. the
> patch description should contain:
>
> What is broken
> How/when it broke (SHA or general timeframe)
> How it's fixed
>
> In this case, it wasn't obvious what the actual breakage was (i.e.
> audio not working), nor when it was introduced.
>
> Of course, if something is trivial you don't need to fill it in, nor
> should it be a form-based description. But those three answers should
> generally be possible to find in the patch description for a bugfix.
Yes, understood. I generally do push back on this and this time I (quite
unnecessarily) tried supplementing the information missing in
description through the tag signing message. Should have made sure the
commit description has the required information instead.
Thanks,
Sekhar
prev parent reply other threads:[~2013-12-04 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 22:28 [GIT PULL] DaVinci fixes for v3.13-rc3 Sekhar Nori
2013-12-04 22:33 ` Olof Johansson
2013-12-04 22:43 ` Sekhar Nori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529FB017.4050102@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.