From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V3 9/9] qapi script: do not add "_" for every capitalized char in enum
Date: Wed, 04 Dec 2013 15:58:38 -0700 [thread overview]
Message-ID: <529FB39E.6090904@redhat.com> (raw)
In-Reply-To: <1385714473-7322-10-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On 11/29/2013 01:41 AM, Wenchao Xia wrote:
> Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT,
> "X86CPU" will generate X86_CPU instead of X86_C_P_U.
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> + l = len(c_fun_str)
> + for i in range(l):
> + c = c_fun_str[i]
> + # When c is upper and no "_" appear before, do more check
s/appear/appears/ s/check/checks/
> + if c.isupper() and (i > 0) and c_fun_str[i - 1] != "_":
> + # Case 1: Next string is lower
> + # Case 2: previous string is digit
> + if (i < (l - 1) and c_fun_str[i + 1].islower()) or \
> + c_fun_str[i - 1].isdigit():
Indentation looks odd.
> + new_name += '_'
> new_name += c
> return new_name.lstrip('_').upper()
Those are minor, so feel free to add:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
prev parent reply other threads:[~2013-12-04 22:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 8:41 [Qemu-devel] [PATCH Resend V3 0/9] qapi script: support enum as discriminator and better enum name Wenchao Xia
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 1/9] qapi script: remember enum values Wenchao Xia
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 2/9] qapi script: add check for duplicated key Wenchao Xia
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 3/9] qapi script: check correctness of discriminator values in union Wenchao Xia
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 4/9] qapi script: code move for generate_enum_name() Wenchao Xia
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 5/9] qapi script: use same function to generate enum string Wenchao Xia
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 6/9] qapi script: support pre-defined enum type as discriminator in union Wenchao Xia
2013-12-03 3:13 ` Eric Blake
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 7/9] tests: add cases for inherited struct and union with discriminator Wenchao Xia
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 8/9] qapi: convert BlockdevOptions to use enum discriminator Wenchao Xia
2013-12-03 3:15 ` Eric Blake
2013-11-29 8:41 ` [Qemu-devel] [PATCH V3 9/9] qapi script: do not add "_" for every capitalized char in enum Wenchao Xia
2013-12-04 22:58 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529FB39E.6090904@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.