From: Qiao Zhou <zhouqiao@marvell.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
Miao Eric <eric.y.miao@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Chao Xie <cxie4@marvell.com>
Subject: Re: [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone
Date: Thu, 5 Dec 2013 09:37:27 +0800 [thread overview]
Message-ID: <529FD8D7.1020900@marvell.com> (raw)
In-Reply-To: <CAPcyv4jELNXN7+f2MvD8FuUmvRCbAw7DG=cNMHuPrYWcWAo5BA@mail.gmail.com>
On 12/05/2013 03:17 AM, Dan Williams wrote:
> On Wed, Dec 4, 2013 at 3:24 AM, Qiao Zhou <zhouqiao@marvell.com> wrote:
>> On 12/04/2013 07:17 PM, Haojian Zhuang wrote:
>>>
>>> Dan indicated that you could pack these two patches into one. Whatever
>>> it's also OK to use two patches.
>>
>> Misunderstood it... Thanks for correcting.
>>
>
> Please combine the patches for two reasons:
> 1/ patch1 by itself makes the problem worse it prevents the mmp_tdma
> driver from building even if CPU_MMP2 is selected.
> 2/ patch2 does not have a changelog and is the only user of the
> enabling in patch1
>
Dan, I updated the patch according to your suggestions. please help take
a look again. Thanks.
--
Best Regards
Qiao
prev parent reply other threads:[~2013-12-05 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 8:21 [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone Qiao Zhou
2013-12-04 8:21 ` [PATCH 1/2] arm: mmp: build sram driver alone Qiao Zhou
2013-12-04 8:21 ` [PATCH 2/2] dma: mmp-tdma: select sram driver Qiao Zhou
2013-12-04 11:17 ` [PATCH 0/2 V1] arm-mmp-build-sram-driver-alone Haojian Zhuang
2013-12-04 11:24 ` Qiao Zhou
2013-12-04 19:17 ` Dan Williams
2013-12-05 1:37 ` Qiao Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529FD8D7.1020900@marvell.com \
--to=zhouqiao@marvell.com \
--cc=cxie4@marvell.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.