From: Guenter Roeck <linux@roeck-us.net>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] sc1200_wdt: Fix oops
Date: Wed, 04 Dec 2013 18:46:49 -0800 [thread overview]
Message-ID: <529FE919.9060604@roeck-us.net> (raw)
In-Reply-To: <20131205001511.6c8e9f60@alan.etchedpixels.co.uk>
On 12/04/2013 04:15 PM, One Thousand Gnomes wrote:
> On Wed, 4 Dec 2013 08:31:18 -0800
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>> On Wed, Dec 04, 2013 at 03:31:52PM +0000, Alan wrote:
>>> If loaded with isapnp = 0 the driver explodes. This is catching
>>> people out now and then. What should happen in the working case is
>>> a complete mystery and the code appears terminally confused, but we
>>
>> Looks like it uses the pnp infrastructure only to auto-detect the
>> "io" address, and assumes that pnp_register_driver() calls the
>> pnp probe function immediately. Afterwards it unregisters and
>> works (or is supposed to work) outside the pnp subsystem. Brr.
>>
>>> can at least make the error path work properly.
>>>
>>> Signed-off-by: Alan Cox <alan@linux.intel.com>
>>> Partially-Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=53991
>>
>> Actually, I think it fully resolves it, because the other part (sc520 driver
>> not working on SC1100 CPU) isn't a bug. It isn't working on an ARM or PPC CPU
>> either, nor on any Intel CPU.
>
> As far as I can tell the fact it fails on the sc1100 is also a bug - but
> the mess of idefs around PNP is impossible to figure out without some
> actual docs, time and real hardware.
>
... unless isapnp was set to 0 via module parameter, or if SC1100 is not compatible
with SC1200. But I agree, hard to say w/o datasheet and hw.
Either case, seems to me the driver is screaming for a substantial overhaul.
Guenter
prev parent reply other threads:[~2013-12-05 2:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 15:31 [PATCH] sc1200_wdt: Fix oops Alan
2013-12-04 16:31 ` Guenter Roeck
2013-12-05 0:15 ` One Thousand Gnomes
2013-12-05 2:46 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529FE919.9060604@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.