Re: [PATCH] tools: ovmf debug build only if tools debug is enabled

[Fabio Fantoni <fabio.fantoni@m2r.biz>]

Il 04/12/2013 17:23, Wei Liu ha scritto:
> On Wed, Dec 04, 2013 at 03:47:02PM +0100, Fabio Fantoni wrote:
> [...]
>> I not found a working parameter to disable the print of instructions
>> to execute, is it really needed?
>> If yes, how should I do it?
>>
>> Thanks for any reply.
> I have a patch in queue for this:
>
>
>  From 646417d80779c592a578a20962aced402d94e580 Mon Sep 17 00:00:00 2001
> From: Wei Liu <wei.liu2@citrix.com>
> Date: Wed, 4 Dec 2013 16:21:23 +0000
> Subject: [PATCH] tools/ovmf-makefile: only build debug target when specified
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Thispatch is better then no longer considered my patch.

> ---
>   tools/firmware/ovmf-makefile |   19 ++++++++++++++-----
>   1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile
> index 073ed44..1ad041f 100644
> --- a/tools/firmware/ovmf-makefile
> +++ b/tools/firmware/ovmf-makefile
> @@ -1,16 +1,25 @@
>   # OVMF building system is not ready yet to run in parallel.
>   # Force it to be serial in order to exploit parallelism for neighbors.
>   
> +XEN_ROOT=$(CURDIR)/../../..
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +ifeq ($(debug),y)
> +TARGET=DEBUG
> +else
> +TARGET=RELEASE
> +endif
> +
>   .NOTPARALLEL:
>   MAKEFLAGS  += -j1
>   
>   .PHONY: all
> -all: ovmf.bin
> +all: build
>   
> -.PHONY: ovmf.bin
> -ovmf.bin:
> -	OvmfPkg/build.sh -a X64
> -	cp Build/OvmfX64/DEBUG_GCC*/FV/OVMF.fd ovmf.bin
> +.PHONY: build
> +build:
> +	OvmfPkg/build.sh -a X64 -b $(TARGET)
> +	cp Build/OvmfX64/$(TARGET)_GCC*/FV/OVMF.fd ovmf.bin
>   
>   .PHONY: clean
>   clean: