All of lore.kernel.org
 help / color / mirror / Atom feed
From: emilio@elopez.com.ar (Emilio López)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Clean up setup printks a bit
Date: Thu, 05 Dec 2013 06:14:47 -0300	[thread overview]
Message-ID: <52A04407.4000306@elopez.com.ar> (raw)
In-Reply-To: <1386199826-8183-1-git-send-email-olof@lixom.net>

Hi Olof,

El 04/12/13 20:30, Olof Johansson escribi?:
> Clean up the setup ARM printks a bit. Add printk level to a few
> that were missing (CPU: <...> ones, in particular), and switch from
> printk(KERN_* ..) to pr_*().
>
> Finally, un-wrap some long lines since it makes it harder to grep the
> sources from where an error came from and tweak some cases of indentation.
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>   arch/arm/kernel/setup.c |   39 +++++++++++++++++++--------------------
>   1 file changed, 19 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index 6a1b8a8..7c472f4 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c

...

>
>   	if (meminfo.nr_banks >= NR_BANKS) {
> -		printk(KERN_CRIT "NR_BANKS too low, "
> -			"ignoring memory at 0x%08llx\n", (long long)start);
> +		pr_crit("NR_BANKS too low, "ignoring memory at 0x%08llx\n",

There's a stray " there

> +			(long long)start);
>   		return -EINVAL;
>   	}
>

Cheers,

Emilio

  parent reply	other threads:[~2013-12-05  9:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 23:30 [PATCH] ARM: Clean up setup printks a bit Olof Johansson
2013-12-04 23:41 ` Russell King - ARM Linux
2013-12-04 23:44   ` Olof Johansson
2013-12-05  9:14 ` Emilio López [this message]
2013-12-05 17:28   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A04407.4000306@elopez.com.ar \
    --to=emilio@elopez.com.ar \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.