Re: [PATCH net] bonding: fix packets_per_slave showing

[Nikolay Aleksandrov <nikolay@redhat.com>]

On 12/05/2013 12:08 PM, Veaceslav Falico wrote:
> On Thu, Dec 05, 2013 at 11:36:58AM +0100, Nikolay Aleksandrov wrote:
>> There's an issue when showing the value of packets_per_slave due to
>> using signed integer. The value may be < 0 and thus not put through
>> reciprocal_value() before showing. This patch makes it use unsigned
>> integer when showing it.
> 
> I was already checking my basic algebra knowledge here,
> reciprocal_value(reciprocal_value(0..USHRT_MAX)) can become negative?!? :)
> 
> If anyone's also wondering...
> 
> packets_per_slave is reciprocal_value(0..USHRT_MAX), and thus can indeed be
> negative, and then the code
> 
>     if (packets_per_slave > 1)
>         packets_per_slave = reciprocal_value(packets_per_slave);
> 
> would fail to recognise that it's a reciprocal_divide() value, and not a
> standard 0/1 option (in bond_rr_gen_slave_id() we verify it via a switch,
> so we're safe there) - and thus output nonsense.
> 
> Acked-by: Veaceslav Falico <vfalico@redhat.com>
> 
Thanks for the review. Indeed, I should've made it unsigned from the beginning
but thought to be consistent with the other options (just don't ask why :) ).
Anyhow, once net-next opens up I can convert it to unsigned completely as it's
supposed to be.

Cheers,
 Nik