All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations
Date: Thu, 05 Dec 2013 15:55:10 +0100	[thread overview]
Message-ID: <52A093CE.60207@kamp.de> (raw)
In-Reply-To: <20131205121528.GA12608@stefanha-thinkpad.redhat.com>

Am 05.12.2013 13:15, schrieb Stefan Hajnoczi:
> On Wed, Nov 27, 2013 at 11:07:00AM +0100, Peter Lieven wrote:
>> this series adds some optimizations for qemu-img during convert which
>> have been developed recently:
>> - skipping input based on get_block_status
>> - variable I/O buffer size
>> - align write requests to cluster_size
>>
>> v2->v3:
>>   - added Paolos comments in Patch 1
>>   - changed the comment in patch 7 [Paolo]
>>   - remove the patch to add sector progress output
>>   - added a new patch to decrease the progress update interval.
>>
>> v1->v2:
>>   - introduce opt_transfer_length in BlockLimits [Paolo]
>>   - remove knobs for iobuffer_size and alignment and
>>     use them unconditionally [Paolo]
>>   - calculate I/O buffer size by BlockLimits information [Paolo]
>>   - change the alignment patch to round down to the
>>     last and not to the next aligned sector [Paolo]
>>   - limit updates in the sector progress output
>>   - new patch to increase the default for min_sparse [Paolo]
>>
>> Peter Lieven (9):
>>   qemu-img: add support for skipping zeroes in input during convert
>>   qemu-img: fix usage instruction for qemu-img convert
>>   block/iscsi: set bdi->cluster_size
>>   block: add opt_transfer_length to BlockLimits
>>   block/iscsi: set bs->bl.opt_transfer_length
>>   qemu-img: dynamically adjust iobuffer size during convert
>>   qemu-img: round down request length to an aligned sector
>>   qemu-img: increase min_sparse to 128 sectors (64kb)
>>   qemu-img: decrease progress update interval on convert
>>
>>  block/iscsi.c             |   10 ++++
>>  include/block/block_int.h |    3 ++
>>  qemu-img.c                |  131 +++++++++++++++++++++++++++------------------
>>  qemu-img.texi             |    2 +-
>>  4 files changed, 93 insertions(+), 53 deletions(-)
> Merged all except patch 8/9.
>
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block
Thank you.

As discussed I've sent the follow-up patch

    [PATCH] qemu-img: make progress output more accurate during convert

to the list some minutes ago.

Peter

      reply	other threads:[~2013-12-05 14:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 10:07 [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert Peter Lieven
2013-11-27 10:17   ` Paolo Bonzini
2013-12-04 16:46   ` Stefan Hajnoczi
2013-12-04 16:51     ` Peter Lieven
2013-12-05 10:30       ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 3/9] block/iscsi: set bdi->cluster_size Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 4/9] block: add opt_transfer_length to BlockLimits Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 5/9] block/iscsi: set bs->bl.opt_transfer_length Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert Peter Lieven
2013-12-05 13:30   ` Eric Blake
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 7/9] qemu-img: round down request length to an aligned sector Peter Lieven
2013-12-04 15:49   ` Stefan Hajnoczi
2013-12-04 15:56     ` Peter Lieven
2013-12-05 10:33       ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb) Peter Lieven
2013-12-04 16:43   ` Stefan Hajnoczi
2013-12-04 16:46     ` Peter Lieven
2013-12-05  2:12       ` Eric Blake
2013-12-05  4:55         ` Peter Lieven
2013-12-05 10:35           ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 9/9] qemu-img: decrease progress update interval on convert Peter Lieven
2013-12-05 12:15 ` [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations Stefan Hajnoczi
2013-12-05 14:55   ` Peter Lieven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A093CE.60207@kamp.de \
    --to=pl@kamp.de \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.