All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: kai.poggensee-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org,
	sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table
Date: Thu, 05 Dec 2013 10:10:18 -0700	[thread overview]
Message-ID: <52A0B37A.2020900@wwwdotorg.org> (raw)
In-Reply-To: <127fe07e18665f93aa8d7c03e03164f1a049ddb6.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>

On 12/03/2013 03:18 PM, Stefan Agner wrote:
> Depending on the regulator version, the voltage table might be 
> different. Use version specific regulator tables in order to
> select correct voltage table. For the following regulator versions
> different voltage tables are now used:
> 
> * TPS658623: Use correct voltage table for SM2 * TPS658643: New
> voltage table for SM2
> 
> Both versions are in use on the Colibri T20 module. Make use of
> the correct tables by requesting the correct SM2 voltage of 1.8V.
> 
> This change is not backward compatible since an old driver is not
> able to correctly set that value. The value 1.8V is out of range
> for the old driver and will refuse to probe the device. The
> regulator starts with default settings and the driver shows
> appropriate error messages.
> 
> On Colibri T20, the old value used to work with TPS658623 since
> the driver applied a wrong voltage table too. However, the
> TPS658643 used on V1.2 devices uses yet another voltage table and
> those broke that pseudo-compatibility. The regulator driver now has
> the correct voltage table for both regulator versions and those the
> correct voltage can be used in the device tree.

Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
(yes, taking this through the MFD tree with patch 1/3 makes sense)

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table
Date: Thu, 05 Dec 2013 10:10:18 -0700	[thread overview]
Message-ID: <52A0B37A.2020900@wwwdotorg.org> (raw)
In-Reply-To: <127fe07e18665f93aa8d7c03e03164f1a049ddb6.1386108712.git.stefan@agner.ch>

On 12/03/2013 03:18 PM, Stefan Agner wrote:
> Depending on the regulator version, the voltage table might be 
> different. Use version specific regulator tables in order to
> select correct voltage table. For the following regulator versions
> different voltage tables are now used:
> 
> * TPS658623: Use correct voltage table for SM2 * TPS658643: New
> voltage table for SM2
> 
> Both versions are in use on the Colibri T20 module. Make use of
> the correct tables by requesting the correct SM2 voltage of 1.8V.
> 
> This change is not backward compatible since an old driver is not
> able to correctly set that value. The value 1.8V is out of range
> for the old driver and will refuse to probe the device. The
> regulator starts with default settings and the driver shows
> appropriate error messages.
> 
> On Colibri T20, the old value used to work with TPS658623 since
> the driver applied a wrong voltage table too. However, the
> TPS658643 used on V1.2 devices uses yet another voltage table and
> those broke that pseudo-compatibility. The regulator driver now has
> the correct voltage table for both regulator versions and those the
> correct voltage can be used in the device tree.

Acked-by: Stephen Warren <swarren@nvidia.com>
(yes, taking this through the MFD tree with patch 1/3 makes sense)

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Stefan Agner <stefan@agner.ch>,
	thierry.reding@gmail.com, dev@lynxeye.de, lee.jones@linaro.org,
	lgirdwood@gmail.com, broonie@kernel.org
Cc: kai.poggensee@avionic-design.de, sameo@linux.intel.com,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table
Date: Thu, 05 Dec 2013 10:10:18 -0700	[thread overview]
Message-ID: <52A0B37A.2020900@wwwdotorg.org> (raw)
In-Reply-To: <127fe07e18665f93aa8d7c03e03164f1a049ddb6.1386108712.git.stefan@agner.ch>

On 12/03/2013 03:18 PM, Stefan Agner wrote:
> Depending on the regulator version, the voltage table might be 
> different. Use version specific regulator tables in order to
> select correct voltage table. For the following regulator versions
> different voltage tables are now used:
> 
> * TPS658623: Use correct voltage table for SM2 * TPS658643: New
> voltage table for SM2
> 
> Both versions are in use on the Colibri T20 module. Make use of
> the correct tables by requesting the correct SM2 voltage of 1.8V.
> 
> This change is not backward compatible since an old driver is not
> able to correctly set that value. The value 1.8V is out of range
> for the old driver and will refuse to probe the device. The
> regulator starts with default settings and the driver shows
> appropriate error messages.
> 
> On Colibri T20, the old value used to work with TPS658623 since
> the driver applied a wrong voltage table too. However, the
> TPS658643 used on V1.2 devices uses yet another voltage table and
> those broke that pseudo-compatibility. The regulator driver now has
> the correct voltage table for both regulator versions and those the
> correct voltage can be used in the device tree.

Acked-by: Stephen Warren <swarren@nvidia.com>
(yes, taking this through the MFD tree with patch 1/3 makes sense)

  parent reply	other threads:[~2013-12-05 17:10 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 22:18 [PATCH v4 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-12-03 22:18 ` Stefan Agner
2013-12-03 22:18 ` Stefan Agner
2013-12-03 22:18 ` [PATCH v4 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-12-03 22:18   ` Stefan Agner
     [not found]   ` <77384d24810d9a22fc04cad6f7468f54a9cbaafe.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-04  8:10     ` Lee Jones
2013-12-04  8:10       ` Lee Jones
2013-12-04  8:10       ` Lee Jones
2013-12-04  8:40       ` Stefan Agner
2013-12-04  8:40         ` Stefan Agner
     [not found]         ` <e2ae7b9602d0c1e11f8e56ced17e9da0-XLVq0VzYD2Y@public.gmane.org>
2013-12-04 10:07           ` Lee Jones
2013-12-04 10:07             ` Lee Jones
2013-12-04 10:07             ` Lee Jones
2013-12-04 11:38             ` Stefan Agner
2013-12-04 11:38               ` Stefan Agner
2013-12-04 11:48               ` Lee Jones
2013-12-04 11:48                 ` Lee Jones
2013-12-04 11:49             ` Mark Brown
2013-12-04 11:49               ` Mark Brown
2013-12-04 11:49               ` Mark Brown
     [not found]               ` <20131204114909.GK29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-04 11:58                 ` Lee Jones
2013-12-04 11:58                   ` Lee Jones
2013-12-04 11:58                   ` Lee Jones
2013-12-05 17:06     ` Stephen Warren
2013-12-05 17:06       ` Stephen Warren
2013-12-05 17:06       ` Stephen Warren
2013-12-05 17:43       ` Stefan Agner
2013-12-05 17:43         ` Stefan Agner
2013-12-05 17:43         ` Stefan Agner
2013-12-05 17:40         ` Stephen Warren
2013-12-05 17:40           ` Stephen Warren
     [not found]           ` <52A0BA85.4020201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-05 22:56             ` Stefan Agner
2013-12-05 22:56               ` Stefan Agner
2013-12-05 22:56               ` Stefan Agner
     [not found]               ` <ac11b85d05765b3b68eff8c27041e965-XLVq0VzYD2Y@public.gmane.org>
2013-12-06  8:44                 ` Lee Jones
2013-12-06  8:44                   ` Lee Jones
2013-12-06  8:44                   ` Lee Jones
     [not found] ` <cover.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-03 22:18   ` [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table Stefan Agner
2013-12-03 22:18     ` Stefan Agner
2013-12-03 22:18     ` Stefan Agner
     [not found]     ` <127fe07e18665f93aa8d7c03e03164f1a049ddb6.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-04  9:48       ` Thierry Reding
2013-12-04  9:48         ` Thierry Reding
2013-12-04  9:48         ` Thierry Reding
2013-12-04 12:14       ` Mark Brown
2013-12-04 12:14         ` Mark Brown
2013-12-04 12:14         ` Mark Brown
2013-12-04 14:17         ` Stefan Agner
2013-12-04 14:17           ` Stefan Agner
     [not found]           ` <0983a0fa016faa5674834afad4472413-XLVq0VzYD2Y@public.gmane.org>
2013-12-04 14:29             ` Mark Brown
2013-12-04 14:29               ` Mark Brown
2013-12-04 14:29               ` Mark Brown
     [not found]               ` <20131204142954.GW29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-04 14:40                 ` Lee Jones
2013-12-04 14:40                   ` Lee Jones
2013-12-04 14:40                   ` Lee Jones
2013-12-05 17:10       ` Stephen Warren [this message]
2013-12-05 17:10         ` Stephen Warren
2013-12-05 17:10         ` Stephen Warren
2013-12-03 22:18   ` [PATCH v4 3/3] ARM: tegra: correct Colibri T20 regulator settings Stefan Agner
2013-12-03 22:18     ` Stefan Agner
2013-12-03 22:18     ` Stefan Agner
     [not found]     ` <fc7440a2f4bf9ab95e47a911c0e0b3b6a2250356.1386108712.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2013-12-04 11:52       ` Lucas Stach
2013-12-04 11:52         ` Lucas Stach
2013-12-04 11:52         ` Lucas Stach
2013-12-05 17:12       ` Stephen Warren
2013-12-05 17:12         ` Stephen Warren
2013-12-05 17:12         ` Stephen Warren
2013-12-05 17:33         ` Stefan Agner
2013-12-05 17:33           ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A0B37A.2020900@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
    --cc=kai.poggensee-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=stefan-XLVq0VzYD2Y@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.