From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VociW-0000lx-FD
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 12:28:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VociQ-0004cJ-5A
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 12:28:00 -0500
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=39668
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VociP-0004bd-VK
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 12:27:54 -0500
Message-ID: <52A0B78C.6000207@weilnetz.de>
Date: Thu, 05 Dec 2013 18:27:40 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1386264247-25867-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1386264247-25867-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix compilation for older
 versions of glib (bug #1258168)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@amazon.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel <qemu-devel@nongnu.org>, Don Slutz <dslutz@verizon.com>, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <mlureau@redhat.com>, Laurent Desnogues <laurent.desnogues@gmail.com>, Alon Levy <alevy@redhat.com>

Am 05.12.2013 18:24, schrieb Stefan Weil:
> See https://bugs.launchpad.net/bugs/1258168
>
> libcacard/vscclient.c: In function 'do_socket_read':
> libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached'
> libcacard/vscclient.c:410: warning: nested extern declaration of 'g_warn_if_reached'
> libcacard/vscclient.c: In function 'main':
> libcacard/vscclient.c:763: warning: implicit declaration of function 'g_byte_array_unref'
> libcacard/vscclient.c:763: warning: nested extern declaration of 'g_byte_array_unref'
> ...
> libcacard/vscclient.o: In function `do_socket_read':
> libcacard/vscclient.c:410: undefined reference to `g_warn_if_reached'
> libcacard/vscclient.o: In function `main':
> libcacard/vscclient.c:763: undefined reference to `g_byte_array_unref'
>
> g_warn_if_reached was added in glib 2.16, and g_byte_array_unref is
> supported since glib 2.22. QEMU requires glib 2.16, so both names must

Please fix before committing: QEMU requires glib 2.12, ...

Thank you,
Stefan


> not be used.