From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53397)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VodvL-0000rb-Lr
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 13:45:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VodvD-0003dk-80
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 13:45:19 -0500
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=60084
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VodvD-0003df-19
	for qemu-devel@nongnu.org; Thu, 05 Dec 2013 13:45:11 -0500
Message-ID: <52A0C9B1.1050408@weilnetz.de>
Date: Thu, 05 Dec 2013 19:45:05 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1386264247-25867-1-git-send-email-sw@weilnetz.de>
	<52A0BFFC.3030808@terremark.com>
In-Reply-To: <52A0BFFC.3030808@terremark.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix compilation for older
 versions of glib (bug #1258168)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>, Anthony Liguori <aliguori@amazon.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <mlureau@redhat.com>, Alon Levy <alevy@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

Am 05.12.2013 19:03, schrieb Don Slutz:
> On 12/05/13 12:24, Stefan Weil wrote:
[...]
>>   @@ -760,7 +760,7 @@ main(
>>         g_io_channel_unref(channel_stdin);
>>       g_io_channel_unref(channel_socket);
>> -    g_byte_array_unref(socket_to_send);
>> +    g_byte_array_free(socket_to_send);
>>   
> This fails with:
>
> /home/don/qemu/libcacard/vscclient.c: In function 'main':
> /home/don/qemu/libcacard/vscclient.c:763: error: too few arguments to
> function 'g_byte_array_free'
> make: *** [libcacard/vscclient.o] Error 1
>
> The bug included ", TRUE"...
>    -Don Slutz
>>       closesocket(sock);
>>       return 0;
>


Sorry, I should have waited until the compile test was finished before
sending this patch.
v2 with fixed commit message and fixed call of g_byte_array was sent a
minute ago.

Stefan Weil