Re: [PATCH net v5 1/2] net: sched: tbf: fix calculation of max_size

[Yang Yingliang <yangyingliang@huawei.com>]

On 2013/12/6 11:46, Eric Dumazet wrote:
> On Fri, 2013-12-06 at 10:24 +0800, Yang Yingliang wrote:
>> Hi, Eric
>> Thanks for your reviewing and advice!
>>
>> On 2013/12/5 20:15, Eric Dumazet wrote:
>>> On Thu, 2013-12-05 at 15:10 +0800, Yang Yingliang wrote:
>>>>
>>>> Suggested-by: Jesper Dangaard Brouer <jbrouer@redhat.com>
>>>> Suggested-by: Eric Dumazet <edumazet@google.com>
>>>
>>> No, I did not suggest this patch.
>>
>> You suggested that
>>
>> 	if (qopt->rate.linklayer == TC_LINKLAYER_UNAWARE)
>> 	    qdisc_put_rtab(qdisc_get_rtab(&qopt->rate,
>> 				          tb[TCA_TBF_RTAB]));
>>
>> so I added your suggestion.
> 
> OK : The exact meaning of 'Suggested-by: XX' is :
> 
> 1) the patch idea was given by XX.
> 2) Then you implemented it.
> 
> This is not really the case here : You had the idea of this patch.
> 
> I made some feedbacks, you have no special tag to add for that.
> 
> Later, if I agree with your next patch set I'll add my own
> "Acked-by: ..."
> 
> If not (for example I am slow to respond and it got merged), its not a
> big deal.
> 
> Thanks
> 

Got it.
Thanks for your explanation!

> 
> 
>