From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: nand: omap: fix ecc-layout for HAM1 ecc-scheme
Date: Fri, 06 Dec 2013 08:02:33 +0100 [thread overview]
Message-ID: <52A17689.2060009@denx.de> (raw)
In-Reply-To: <1386246261-29456-1-git-send-email-pekon@ti.com>
On 05.12.2013 13:24, Pekon Gupta wrote:
> As per OMAP3530 TRM referenced below [1]
>
> For large-page NAND, ROM code expects following ecc-layout for HAM1 ecc-scheme
> - OOB[1] (offset of 1 *byte* from start of OOB) for x8 NAND device
> - OOB[2] (offset of 1 *word* from start of OOB) for x16 NAND device
>
> Thus ecc-layout expected by ROM code for HAM1 ecc-scheme is:
> *for x8 NAND Device*
> +--------+---------+---------+---------+---------+---------+---------+
> | xxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] | ...
> +--------+---------+---------+---------+---------+---------+---------+
>
> *for x16 NAND Device*
> +--------+--------+---------+---------+---------+---------+---------+---------+
> | xxxxx | xxxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] |
> +--------+--------+---------+---------+---------+---------+---------+---------+
>
> This patch fixes ecc-layout *only* for HAM1, as required by ROM-code
> For other ecc-schemes like (BCH8) ecc-layout is same for x8 or x16 devices.
>
> [1] OMAP3530: http://www.ti.com/product/omap3530
> TRM: http://www.ti.com/litv/pdf/spruf98x
> Chapter-25: Initialization Sub-topic: Memory Booting
> Section: 25.4.7.4 NAND
> Figure 25-19. ECC Locations in NAND Spare Areas
>
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Pekon Gupta <pekon@ti.com>
This fixes the problem I reported. Tested again on x8 and x16 NAND
OMAP3530 targets. Thanks Pekon!
Tested-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
next prev parent reply other threads:[~2013-12-06 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 12:24 [U-Boot] [PATCH] mtd: nand: omap: fix ecc-layout for HAM1 ecc-scheme Pekon Gupta
2013-12-06 7:02 ` Stefan Roese [this message]
2013-12-17 23:26 ` [U-Boot] " Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A17689.2060009@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.