From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH] ASoC: omap-pcm: Lower the dma coherent mask to 32bits
Date: Fri, 6 Dec 2013 11:31:52 +0200 [thread overview]
Message-ID: <52A19988.9060806@ti.com> (raw)
In-Reply-To: <20131205192853.GH4360@n2100.arm.linux.org.uk>
On 12/05/2013 09:28 PM, Russell King - ARM Linux wrote:
> gives us the very last PFN which the bus associated with dev is able to
> address. Hmm - so I got the test wrong on both twice - they should both
> be:
>
> if (sizeof(mask) != sizeof(dma_addr_t) &&
> mask > (dma_addr_t)~0 &&
> dma_to_pfn(dev, ~0) < min(max_pfn, arm_dma_pfn_limit))
> return 0;
>
> since we want to fail if we have _more_ memory than the bus will allow.
> Can you try the above in both locations please?
Thanks, works fine.
I will be out for a long weekend so you can add my:
Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
to the final patch.
--
Péter
next prev parent reply other threads:[~2013-12-06 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 8:06 [PATCH] ASoC: omap-pcm: Lower the dma coherent mask to 32bits Peter Ujfalusi
2013-12-05 9:56 ` Russell King - ARM Linux
2013-12-05 15:33 ` Peter Ujfalusi
2013-12-05 19:28 ` Russell King - ARM Linux
2013-12-05 20:11 ` Takashi Iwai
2013-12-05 21:07 ` Russell King - ARM Linux
2013-12-06 8:12 ` Takashi Iwai
2013-12-06 12:25 ` Russell King - ARM Linux
2013-12-06 13:04 ` Takashi Iwai
2013-12-09 9:56 ` Peter Ujfalusi
2013-12-09 17:03 ` Russell King - ARM Linux
2013-12-10 9:37 ` Peter Ujfalusi
2013-12-10 10:00 ` Peter Ujfalusi
2013-12-13 11:46 ` Peter Ujfalusi
2013-12-13 11:49 ` Russell King - ARM Linux
2013-12-13 11:50 ` Peter Ujfalusi
2013-12-06 9:31 ` Peter Ujfalusi [this message]
2013-12-06 12:33 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A19988.9060806@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.