Re: [PATCH net-next] unix: convert printks to pr_<level>

[Wang Weidong <wangweidong1@huawei.com>]

On 2013/12/6 17:40, Daniel Borkmann wrote:
> On 12/06/2013 10:32 AM, Wang Weidong wrote:
>> On 2013/12/6 17:22, Daniel Borkmann wrote:
>>> On 12/06/2013 07:09 AM, Wang Weidong wrote:
>>>> use pr_<level> instead of printk(LEVEL)
>>>>
>>>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
>>>> ---
>>>>    net/unix/af_unix.c |   10 ++++++----
>>>>    1 files changed, 6 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
>>>> index 4155ed3..ca98e61 100644
>>>> --- a/net/unix/af_unix.c
>>>> +++ b/net/unix/af_unix.c
>>>> @@ -80,6 +80,9 @@
>>>>     *          with BSD names.
>>>>     */
>>>>
>>>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>>>> +#define DEBUG
>>>> +
>>>
>>> Why do you define DEBUG here ?
>>>
>> I think the pr_debug != printk(KERN_DEBUG), equal when define DEBUG.
> 
> Ok, then please read Documentation/dynamic-debug-howto.txt
> 
> pr_debug() is part of the dynamic debugging framework and
> can be enabled / disabled at runtime when configured. So
> that define does not belong here.
> 
Yes, You are right. I will fix it.

Thanks.

>