Re: arbitration lost error reporting

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 06.12.2013 12:45, Marc Kleine-Budde wrote:
> On 12/06/2013 11:57 AM, Richard Andrysek wrote:
>>> You can send a diff, to illustrate your changes.
>>
>> $ diff /cygdrive/X/bug1/sja1000.c /cygdrive/X/modified_sja1000.c
> 
> "diff -u" is preferred, but no need to resend it.
> 
>>>> But I prefare to make some kind of "ioctl" support for that. There are
>>>> applications, where it shall not happend. Concurrently I've played with
>>>> taskset and priorities.
>>>
>>> ioctl() is not a option here, but there are two options:
>>> 1) We can put the arbitration lost error to the bus errors,
>>>    but I think that's wrong.
>>> 2) You can add another ctrlmode to disable arbitration lost error
>>>    reporting.
> 
>> As Wolgang mentioned it has nothing to do with the patch v6.
>> Enabling/diabling IRQs is a new feature. So I don't know, if here it is a
>> right place to continue about that.
> 
> Yes, why not? :)
> As I outlined above you have two options. I prefer option 2 and it has a
> big change of going mainline. The implementation is similar to
> CAN_CTRLMODE_BERR_REPORTING, just look for it in the kernel source tree
> and add a new define for arbitration lost error reporting.
> 
> Do you have a preferred name for the define?
> - CAN_CTRLMODE_AERR_REPORTING
> - CAN_CTRLMODE_ARBITRATIONERR_REPORTING to

Loosing the arbitration is not an error. It just can happen from time to time.

If you thing about a define, what about:

CAN_CTRLMODE_ARB_LOST_REPORTING
CAN_CTRLMODE_ARBITRATION_LOST_REPORTING

Regards,
Oliver